Fix PerfMonitor appearance when reloading JS #24073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @usrbowe in 15619c2. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Mar 29, 2019
Summary: Fix for this issue I rasied: #24024 When I toggle `Show Perf Monitor` and reload JS `CMD+R` the Perf Monitor will be hidden, but settings in dev menu will persist. So to fix this state and need to `Hide Perf Monitor` and `Show Perf Monitor` again to see it. [iOS] [Fixed] - Show Perf Monitor, after reloading JS Pull Request resolved: #24073 Differential Revision: D14560025 Pulled By: cpojer fbshipit-source-id: cd5602bd6ee041b8b3e61d163d10bd8bc47237b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for this issue I rasied: #24024
When I toggle
Show Perf Monitorand reload JSCMD+Rthe Perf Monitor will be hidden, but settings in dev menu will persist. So to fix this state and need toHide Perf MonitorandShow Perf Monitoragain to see it.Changelog
[iOS] [Fixed] - Show Perf Monitor, after reloading JS
Test Plan
Toggle Perf Monitor to be visible. Reload JS (CMD+R). If Perf Monitor visible all good.