Fix jsc-android not found if building from source

[Kudo]

Summary

If an app builds from RN source, there was an error for jsc-android not found.
It is a side effect of my previous JSC as node dependency change
For building from RN source case, the jsc-android is located at /path/to/app/node_modules/jsc-android.
Original gradle task will try to find it at /path/to/app/node_modules/react-native/ReactAndroid/../node_modules/jsc-android, as ReactAndroid project path was being override inside node_modules.
The change fixes the building from source case.

Changelog

N/A
This change does not need to publish into changelog, as it is a master branch building fix.

Test Plan

1. Test building RN AAR: ./gradlew :ReactAndroid:installArchives
2. Test an app to build from source as described at https://facebook.github.io/react-native/docs/building-from-source

[pull-bot]

Messages

📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 960ad9f

[janicduplessis]

@Kudo Would it be possible to make the path configurable? I'm using yarn workspaces and RN is not installed in /path/to/app/node_modules.

[janicduplessis]

Maybe a better alternative would be to use $projectDir/../../jsc-android/dist instead. That way it should work with most monorepo configs, since it will look in the same directory where RN is installed.

[Kudo]

@janicduplessis Good idea, please let me update accordingly.

[cpojer]

Thanks for this fix!

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @Kudo in 040502b.

^{When will my fix make it into a release? | Upcoming Releases}

[facebook-github-bot]

@cpojer merged this pull request in 040502b.