Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix test_android instrumentation tests #24561

Closed

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Apr 22, 2019

Summary

It seems that react_native_dep("android_res/com/facebook/catalyst/appcompat:appcompat") is no longer used. fixes #24537

Changelog

[Android] [Changed] - fix CI instrumentation tests

Test Plan

CI is green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Partner labels Apr 22, 2019
@dulmandakh dulmandakh added Platform: Android Android applications. and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Partner Contributor A React Native contributor. labels Apr 22, 2019
@react-native-bot react-native-bot added the No CLA Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos hramos changed the title fix CI instrumentation tests [CI] Fix test_android instrumentation tests Apr 23, 2019
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dulmandakh in ebed815.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 23, 2019
@dulmandakh dulmandakh deleted the fix-ci-instrumentation branch October 15, 2019 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged This PR has been merged. No CLA Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Test Failure: D14950721 - test_android failing after androidx Buck update
3 participants