Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[standards] Migrate vendored JS from Haste to path-based imports #24769

Closed
ide opened this issue May 8, 2019 · 0 comments
Closed

[standards] Migrate vendored JS from Haste to path-based imports #24769

ide opened this issue May 8, 2019 · 0 comments
Labels
p: Expo Partner: Expo Partner Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@ide
Copy link
Contributor

ide commented May 8, 2019

The Set & Map polyfills and EventEmitter under Libraries/vendor use Haste. We can easily rewrite the imports in the vendored code, but we can make things easier for the next person who re-syncs the vendored code from the source by rewriting the imports in the pre-vendored code. (I could be mistaken about this, since Libraries/vendor/document/selection/DocumentSelectionState.js uses path-based imports.)

There are two parts to this issue:

  1. Deciding whether to update the pre- or post-vendored code. We will update the post-vendored code.
  2. Rewriting the imports inside of Facebook's source of truth (pre-vendored) or submitting a PR to rewrite only the code on GitHub (post-vendored).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: Expo Partner: Expo Partner Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants