[RNTester] Remove ToolbarAndroid #24999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-native-bot
added
Component: ToolbarAndroid
Platform: Android
facebook-github-bot
added
CLA Signed
cpojer
approved these changes
May 23, 2019
facebook-github-bot
approved these changes
May 23, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @ericlewis in 82771f4. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: This replaces ToolbarAndroid with a cleaner, but very similar design and paves the path for removing ToolbarAndroid from core. ## Changelog [Internal] [Removed] - ToolbarAndroid removed from RNTester Pull Request resolved: facebook#24999 Differential Revision: D15468053 Pulled By: cpojer fbshipit-source-id: 21a58558b9ec371689bc994c2d888b81cff01126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces ToolbarAndroid with a cleaner, but very similar design and paves the path for removing ToolbarAndroid from core.
Changelog
[Internal] [Removed] - ToolbarAndroid removed from RNTester
Test Plan
Make sure the menu button still works + that it looks okay. See the preview below.