TM: Backward compatibility of calling invalidate on module's method queue #25264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @zhongwuzw in af59323. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
…ueue (facebook#25264) Summary: Backward compatibility for `invalidate` method, because for the old module system, we ensure call all methods of modules on `methodQueue`, we also need to keep this rule to avoid some race condition in module. ## Changelog [iOS] [Fixed] - Backward compatibility of calling invalidate on module's method queue Pull Request resolved: facebook#25264 Test Plan: Ensure `invalidate` method of `module` be called on `methodQueue`. Reviewed By: PeteTheHeat, JoshuaGross Differential Revision: D15944532 Pulled By: fkgozali fbshipit-source-id: e260792bc6b86a48cdf376282063cbabccbf26f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backward compatibility for
invalidatemethod, because for the old module system, we ensure call all methods of modules onmethodQueue, we also need to keep this rule to avoid some race condition in module.Changelog
[iOS] [Fixed] - Backward compatibility of calling invalidate on module's method queue
Test Plan
Ensure
invalidatemethod ofmodulebe called onmethodQueue.