Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(gradle): update build.gradle #25810

Closed
wants to merge 1 commit into from
Closed

build(gradle): update build.gradle #25810

wants to merge 1 commit into from

Conversation

ferdicus
Copy link
Contributor

@ferdicus ferdicus commented Jul 25, 2019

Remove obsolete supportLibVersion - no longer required with AndroidX

Summary

Removing the supportLibVersion variable that was used in app/build.gradle to suffix version numbers on android support libraries.
As react-native moved to androidX with the release of 0.60 this is no longer necessary.

Changelog

[Android] [Removed] - Remove supportLibVersion variable in build.gradle

Test Plan

No tests were run locally

Remove obsolete supportLibVersion - no longer required with AndroidX
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 94966e2

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mdvacca mdvacca requested a review from dulmandakh July 25, 2019 07:49
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osdnk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@osdnk osdnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hope it won't break internals

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @ferdicus in fee7f06.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants