Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify missing step #2619

Merged
merged 2 commits into from Sep 9, 2015
Merged

Specify missing step #2619

merged 2 commits into from Sep 9, 2015

Conversation

JonathanHayward
Copy link
Contributor

The instructions as given did not work. The reason they did not work was that, while my .bashrc was made aware of nvm, my running bash process did not know about nvm until I ran ". ~/bashrc", after which things worked as expected.

The instructions as given did not work. The reason they did not work was that, while my .bashrc was made aware of nvm, my running bash process did not know about nvm until I ran ". ~/bashrc", after which things worked as expected.
@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 9, 2015
@ide
Copy link
Contributor

ide commented Sep 9, 2015

Can you word this to say to reopen the terminal window so we cover bash_profile et al?

@JonathanHayward
Copy link
Contributor Author

@ide I've changed the wording; does this work better?

@ide
Copy link
Contributor

ide commented Sep 9, 2015

Yep, thanks!

ide pushed a commit that referenced this pull request Sep 9, 2015
@ide ide merged commit cbed87a into facebook:master Sep 9, 2015
@JonathanHayward JonathanHayward deleted the patch-1 branch September 10, 2015 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants