Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNTester CocoaPods to 1.8.4 #27173

Conversation

friederbluemle
Copy link
Contributor

Summary

This is the second half of #26976 (the CocoaPods update did not make it to master).

@RSNara @hramos @fkgozali @PeteTheHeat - Please take a quick look and comment if there are any known issues with using the latest stable version of CocoaPods. Thanks! 馃檹

It seems like the older version of CocoaPods has a bug that lowercases the spec repo url, even in the unfortunate case that the repo maintainers use upper case characters. This would essentially revert what was fixed in #26976.

Changelog

[General] [Changed] - Update RNTester CocoaPods to 1.8.4

Test Plan

cd RNTester
bundle install
bundle exec pod install

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 8, 2019
Copy link
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing to review and land internally

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @friederbluemle in 30197c3.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 11, 2019
@friederbluemle friederbluemle deleted the update-rntester-cocoapods branch November 11, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants