Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActionSheetIOS): allows using showActionSheetWithOptions in some app extensions #29878

Closed
wants to merge 12 commits into from

Conversation

Etienne-M
Copy link

This fixes #29840. It ended up being much easier than I initially thought. I'm a bit confused as to why the action sheet does not use the RCTAlertController though.

Summary

Allows using the ActionSheetIOS showActionSheetWithOptions inside an app extension granted the developer set up the override of the view controller.

Changelog

[iOS] [Fixed] - ActionSheetIOS.showActionSheetWithOptions method works with RCTUtilsUIOverride.setPresentedViewController

Test Plan

Setup an app extension in react-native. Then,

  1. Use the action sheet without setting the override, see the updated message;
  2. Use the action sheet with the override, it works! 馃帀

@facebook-github-bot
Copy link
Contributor

Hi @Etienne-M!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Sep 7, 2020
@Etienne-M
Copy link
Author

I've signed the CLA and tried to re-trigger the pipeline with a commit, but it still says I haven't signed the CLA 馃槥

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 7, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 902611f

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,209,453 0
android hermes armeabi-v7a 6,858,625 0
android hermes x86 7,644,089 0
android hermes x86_64 7,535,033 0
android jsc arm64-v8a 9,369,050 0
android jsc armeabi-v7a 9,010,350 0
android jsc x86 9,231,770 0
android jsc x86_64 9,808,922 0

Base commit: 902611f

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@janicduplessis janicduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

cc @shergin

@Etienne-M
Copy link
Author

@janicduplessis @shergin @dulmandakh I hope you don't mind me tagging you people directly. The PR is quite small and it's been more than a month now. I'm simply worried it fell in between the cracks. Cheers!

@janicduplessis
Copy link
Contributor

@hramos Could you help land this?

@Etienne-M
Copy link
Author

馃槩

@sota000 sota000 added this to Needs Triage in React Native Pull Requests via automation Jul 27, 2021
@Etienne-M
Copy link
Author

I'm no longer working on the project that required this bug fix... I have no clue if it's still relevant and how I could change the code I wrote here to work with the new ActionSheetManager

@Etienne-M Etienne-M closed this Jun 29, 2022
React Native Pull Requests automation moved this from Needs Triage to Closed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ActionSheetIOS not working inside Share extension
5 participants