-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ActionSheetIOS): allows using showActionSheetWithOptions in some app extensions #29878
Conversation
Hi @Etienne-M! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
I've signed the CLA and tried to re-trigger the pipeline with a commit, but it still says I haven't signed the CLA 馃槥 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: 902611f |
Base commit: 902611f |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
cc @shergin
@janicduplessis @shergin @dulmandakh I hope you don't mind me tagging you people directly. The PR is quite small and it's been more than a month now. I'm simply worried it fell in between the cracks. Cheers! |
@hramos Could you help land this? |
馃槩 |
I'm no longer working on the project that required this bug fix... I have no clue if it's still relevant and how I could change the code I wrote here to work with the new |
This fixes #29840. It ended up being much easier than I initially thought. I'm a bit confused as to why the action sheet does not use the RCTAlertController though.
Summary
Allows using the ActionSheetIOS showActionSheetWithOptions inside an app extension granted the developer set up the override of the view controller.
Changelog
[iOS] [Fixed] - ActionSheetIOS.showActionSheetWithOptions method works with RCTUtilsUIOverride.setPresentedViewController
Test Plan
Setup an app extension in react-native. Then,