Remove all PushNotificationIOS refrences #30106
Conversation
|
Hi @Yash2737! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: 7b7c9f2 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Duplicate of #30026 |
|
Updated PR, please check |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -92,7 +91,7 @@ import typeof RCTDeviceEventEmitter from './Libraries/EventEmitter/RCTDeviceEven | |||
| import typeof RCTNativeAppEventEmitter from './Libraries/EventEmitter/RCTNativeAppEventEmitter'; | |||
| import typeof {RootTagContext} from './Libraries/ReactNative/RootTag'; | |||
|
|
|||
| import type {HostComponent as _HostComponentInternal} from './Libraries/Renderer/shims/ReactNativeTypes'; | |||
| import type { HostComponent as _HostComponentInternal } from './Libraries/Renderer/shims/ReactNativeTypes'; | |||
There was a problem hiding this comment.
- 🚫 index.js line 94 – Replace
·HostComponent·as·_HostComponentInternal·withHostComponent·as·_HostComponentInternal(prettier/prettier)
| @@ -316,10 +315,9 @@ module.exports = { | |||
| }, | |||
| get unstable_batchedUpdates(): $PropertyType< | |||
| ReactNative, | |||
| 'unstable_batchedUpdates', | |||
| 'unstable_batchedUpdates' | |||
There was a problem hiding this comment.
- 🚫 index.js line 318 – Insert
,(prettier/prettier)
| > { | ||
| return require('./Libraries/ReactNative/RendererProxy') | ||
| .unstable_batchedUpdates; | ||
| return require('./Libraries/ReactNative/RendererProxy').unstable_batchedUpdates; |
There was a problem hiding this comment.
- 🚫 index.js line 320 – Insert
⏎······(prettier/prettier)
| @@ -448,8 +446,8 @@ if (__DEV__) { | |||
| invariant( | |||
| false, | |||
| 'ListView has been removed from React Native. ' + | |||
| 'See https://fb.me/nolistview for more information or use ' + | |||
| '`deprecated-react-native-listview`.', | |||
| 'See https://fb.me/nolistview for more information or use ' + | |||
There was a problem hiding this comment.
- 🚫 index.js line 449 – Insert
··(prettier/prettier)
| 'See https://fb.me/nolistview for more information or use ' + | ||
| '`deprecated-react-native-listview`.', | ||
| 'See https://fb.me/nolistview for more information or use ' + | ||
| '`deprecated-react-native-listview`.', |
There was a problem hiding this comment.
- 🚫 index.js line 450 – Insert
··(prettier/prettier)
| @@ -464,8 +462,8 @@ if (__DEV__) { | |||
| invariant( | |||
| false, | |||
| 'SwipeableListView has been removed from React Native. ' + | |||
| 'See https://fb.me/nolistview for more information or use ' + | |||
| '`deprecated-react-native-swipeable-listview`.', | |||
| 'See https://fb.me/nolistview for more information or use ' + | |||
There was a problem hiding this comment.
- 🚫 index.js line 465 – Insert
··(prettier/prettier)
| 'See https://fb.me/nolistview for more information or use ' + | ||
| '`deprecated-react-native-swipeable-listview`.', | ||
| 'See https://fb.me/nolistview for more information or use ' + | ||
| '`deprecated-react-native-swipeable-listview`.', |
There was a problem hiding this comment.
- 🚫 index.js line 466 – Insert
··(prettier/prettier)
| 'To get a base64-encoded string from a local image use either of the following third-party libraries:' + | ||
| "* expo-file-system: `readAsStringAsync(filepath, 'base64')`" + | ||
| "* react-native-fs: `readFile(filepath, 'base64')`", | ||
| 'To get a base64-encoded string from a local image use either of the following third-party libraries:' + |
There was a problem hiding this comment.
- 🚫 index.js line 529 – Insert
··(prettier/prettier)
| "* expo-file-system: `readAsStringAsync(filepath, 'base64')`" + | ||
| "* react-native-fs: `readFile(filepath, 'base64')`", | ||
| 'To get a base64-encoded string from a local image use either of the following third-party libraries:' + | ||
| "* expo-file-system: `readAsStringAsync(filepath, 'base64')`" + |
There was a problem hiding this comment.
- 🚫 index.js line 530 – Insert
··(prettier/prettier)
| "* react-native-fs: `readFile(filepath, 'base64')`", | ||
| 'To get a base64-encoded string from a local image use either of the following third-party libraries:' + | ||
| "* expo-file-system: `readAsStringAsync(filepath, 'base64')`" + | ||
| "* react-native-fs: `readFile(filepath, 'base64')`", |
There was a problem hiding this comment.
- 🚫 index.js line 531 – Insert
··(prettier/prettier)
|
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR was closed because it has been stalled for 7 days with no activity. |
Summary
This PR removes all the references of PushNotificationIOS from the application
Changelog
[Lean Core] [cleanup] - Removed the PushNotificationIOS native module from React Native (now lives at https://github.com/react-native-community/push-notification-ios).
Test Plan
Tested by building and running the RNTester app for both Android and iOS to make sure the builds succeed and all the example references are cleanly removed; no issues found.