Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of parameters usage for Share.share #30310

Closed
wants to merge 1 commit into from

Conversation

Gp2mv3
Copy link

@Gp2mv3 Gp2mv3 commented Nov 3, 2020

Documentation clarification for Share.share parameters.

Summary

The sentence about using either message and url is a bit unclear as it can be understood as "Message and url are required". This sentence can lead to errors.
This StackExchange question sums the difference between using "either X and Y" or "either X and Y": https://english.stackexchange.com/questions/414568/one-of-a-and-b-or-one-of-a-or-b

Changelog

I just replaced "and" into "or".

General Changed - Clarification of parameters for Share.share

Test Plan

The doc should be different and show "either message of url".

Documentation clarification for Share.share parameters.
@facebook-github-bot
Copy link
Contributor

Hi @Gp2mv3!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Gp2mv3 Gp2mv3 changed the title Update Share.js Clarification of parameters usage for Share.share Nov 3, 2020
@pull-bot
Copy link

pull-bot commented Nov 3, 2020

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against bb7c7be

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0045621

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,507,199 +11
android hermes armeabi-v7a 7,098,976 +12
android hermes x86 7,945,327 -8
android hermes x86_64 7,856,391 +0
android jsc arm64-v8a 8,971,903 +0
android jsc armeabi-v7a 8,546,801 +0
android jsc x86 8,971,534 +0
android jsc x86_64 9,522,859 +0

Base commit: 0045621

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sota000 sota000 added this to Needs Triage in React Native Pull Requests via automation Jul 27, 2021
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants