-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification of parameters usage for Share.share #30310
Conversation
Documentation clarification for Share.share parameters.
Hi @Gp2mv3! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Base commit: 0045621 |
Base commit: 0045621 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Documentation clarification for Share.share parameters.
Summary
The sentence about using either message and url is a bit unclear as it can be understood as "Message and url are required". This sentence can lead to errors.
This StackExchange question sums the difference between using "either X and Y" or "either X and Y": https://english.stackexchange.com/questions/414568/one-of-a-and-b-or-one-of-a-or-b
Changelog
I just replaced "and" into "or".
General Changed - Clarification of parameters for Share.share
Test Plan
The doc should be different and show "either message of url".