Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Flipper + Bump hermes #31872

Merged
merged 3 commits into from Jul 20, 2021
Merged

Bump Flipper + Bump hermes #31872

merged 3 commits into from Jul 20, 2021

Conversation

Titozzz
Copy link
Collaborator

@Titozzz Titozzz commented Jul 16, 2021

Flipper from 0.91 to 0.93 : 848d599
Bump hermes to 0.8.1

react-native-community/releases#235

mweststrate and others added 3 commits July 16, 2021 15:23
@mweststrate @Titozzz
Bump Flipper to 0.93 (facebook#31708)
5f0e127 
Summary:
Pull Request resolved: facebook#31708

Changelog:
[general][changed] - [iOS] Update Flipper to 0.93.0

Reviewed By: PeteTheHeat

Differential Revision: D29060305

fbshipit-source-id: 2ff109930437bfc90e8ce441fa681de867206397
@Titozzz
Update Podfile.lock
7e14c47
@Titozzz
bump(hermes): bumped hermes to 0.8.1
8233a44 
While current dependencies included the new version in the range, bumping it make sure that no one use the old one because of a lock file
@Titozzz Titozzz requested a review from hramos as a code owner July 16, 2021 13:44
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2021
@Titozzz Titozzz mentioned this pull request Jul 16, 2021
Closed
9 tasks
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 8233a44

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,901,141 -222,725
android hermes armeabi-v7a 8,388,065 -261,832
android hermes x86 9,350,110 -213,108
android hermes x86_64 9,295,570 -233,825
android jsc arm64-v8a 10,585,627 -179,535
android jsc armeabi-v7a 9,461,740 -220,708
android jsc x86 10,621,595 -178,310
android jsc x86_64 11,210,796 -196,786

Base commit: 1465c8f

@grabbou
Copy link
Contributor

grabbou commented Jul 19, 2021

LGTM.

@Huxpro Huxpro merged commit e53745e into facebook:0.65-stable Jul 20, 2021
@NOUIY NOUIY mentioned this pull request Apr 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Titozzz @pull-bot @analysis-bot @grabbou @Huxpro @facebook-github-bot @mweststrate