Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump metro to 0.66.2 + dedup #31886

Merged
merged 1 commit into from Jul 20, 2021

Conversation

Titozzz
Copy link
Collaborator

@Titozzz Titozzz commented Jul 20, 2021

Summary

Bumped metro to 0.66.2

Couldn't really cherry pick the bump from master cause they diverted quite a bit, I bumped metro (and that bumped babel...) then I used yarn-deduplicate to get the smallest, cleanest change possible.

@Titozzz Titozzz requested a review from hramos as a code owner July 20, 2021 22:59
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 20, 2021
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against fed6e57

@Huxpro Huxpro merged commit e40f582 into facebook:0.65-stable Jul 20, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,919,566 -205,578
android hermes armeabi-v7a 8,406,496 -244,671
android hermes x86 9,368,527 -195,956
android hermes x86_64 9,313,998 -216,662
android jsc arm64-v8a 10,594,882 -170,768
android jsc armeabi-v7a 9,470,993 -211,945
android jsc x86 10,630,846 -169,545
android jsc x86_64 11,220,053 -188,027

Base commit: b0e39b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants