@DoNotStripAny annotation is missing in the Proguard Setup for React Native Android

[cortinico]

Description

I'm opening this public issue if someone from the community wants to pick this up.

We do have several classes that are using the @DoNotStripAny annotation:

$ rg DoNotStripAny

ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.java
10:import com.facebook.proguard.annotations.DoNotStripAny;
12:@DoNotStripAny

ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolverManager.java
12:import com.facebook.proguard.annotations.DoNotStripAny;
16:@DoNotStripAny

ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
37:import com.facebook.proguard.annotations.DoNotStripAny;
97:@DoNotStripAny

ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java
10:import com.facebook.proguard.annotations.DoNotStripAny;
19:@DoNotStripAny

This annotation is actually not included in the Proguard file that we ship alongside ReactAndroid: https://github.com/facebook/react-native/blob/main/ReactAndroid/proguard-rules.pro

It's configuration it's only available in this file which is consumed by Buck:
https://github.com/facebook/react-native/blob/main/ReactAndroid/src/main/java/com/facebook/proguard/annotations/proguard_annotations.pro

We should adapt the former proguard file to include the Proguard config for @DoNotStripAny.
Ideally also doing a run with Proguard and verify that the classes are also not stripped would be great.

Happy to review a PR addressing this, which should be also easy to jump on.

Version

0.67.1

Output of npx react-native info

N/A

Steps to reproduce

N/A

Snack, code example, screenshot, or link to a repository

N/A

[lunaleaps]

@cortinico Does this qualify as a blocking issue for 0.68?

[cortinico]

@cortinico Does this qualify as a blocking issue for 0.68?

Nope is not a blocker. Users on Android + New Architecture (which is opt-in) + Building Release + Using Proguard will face problems. They can still provide extra rules locally to circumvent the problem. Still something we want to offer (so quite important, thought not a hard blocker).

[ShikaSD]

Fixed by 48318b1