Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation clarification suggestion - Android Native modules section. #3475

Closed
dsandor opened this issue Oct 17, 2015 · 1 comment
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@dsandor
Copy link
Contributor

dsandor commented Oct 17, 2015

This paragraph is a bit confusing:

The package needs to be provided to the ReactInstanceManager when it is built. See UIExplorerActivity.java for an example. The default package when you initialize a new project is MainReactPackage.java.

Could we include some additional details to telegraph to a new developer where to actually place the code listed below?

I suggest changing the paragraph to this:

The package needs to be provided to the ReactInstanceManager when it is built. To accomplish this you will need to insert an .addPackage(new YourPackageName()) call to the mReactInstanceManager = ReactInstanceManager.builder() call chain.

Refer to the code below and add the addPackage statement to your application's MainActivity.java file. This file exists under the android folder in your react-native application directory. The path to this file is: android/app/src/main/java/com/your-app-name/MainActivity.java.

@brentvatne
Copy link
Collaborator

Sounds good, please re-open as a PR! 😄 Thanks!

@facebook facebook locked as resolved and limited conversation to collaborators Jul 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants