Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Animated] Optimize by moving animation to a high priority thread #3579

Closed
oblador opened this issue Oct 21, 2015 · 10 comments
Closed

[Animated] Optimize by moving animation to a high priority thread #3579

oblador opened this issue Oct 21, 2015 · 10 comments
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.

Comments

@oblador
Copy link
Contributor

oblador commented Oct 21, 2015

Loving the Animated API, but in some areas, such as interpolating on scroll events, the performance is not always 100%. There's been talk of moving that part off the JS thread into native code since 0.8.0, but couldn't find an issue tracking this.

I think animation performance affects UX of basically every app and will solve some issues with Navigator among others. Would be nice to hear if this is being worked on or if help is wanted.

@skv-headless
Copy link
Contributor

👍

@chirag04
Copy link
Contributor

it would be helpful to add help wanted tag if this is not worked on at fb.

cc @ide @sahrens @vjeux

@ide ide added the Help Wanted :octocat: Issues ideal for external contributors. label Oct 23, 2015
@PhilippKrone
Copy link
Contributor

@oblador Does it mean that you are going to work on this? ;)

@oblador
Copy link
Contributor Author

oblador commented Oct 28, 2015

@PhilippKrone: Talked to vjeux on reactiflux a few days ago about it and from I what understood it's being worked on and that he recently spun up a whole team just working with performance optimizations.

@vjeux
Copy link
Contributor

vjeux commented Oct 28, 2015

Right now the focus of the team is on start performance. No one is actively working on animation perf

@oblador
Copy link
Contributor Author

oblador commented Nov 25, 2015

Related Product Pains post.

@mkonicek
Copy link
Contributor

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/animated-optimize-by-moving-animation-to-a-high-priority-thread

ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.

Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@jnak
Copy link

jnak commented Apr 10, 2016

@mkonicek There is already a product pains post here that has already 151 votes.

You should delete the one you just created

@ide
Copy link
Contributor

ide commented Apr 11, 2016

This is landing soon for Android anyway.

@oblador
Copy link
Contributor Author

oblador commented Apr 11, 2016

@ide: Yes, that's very exciting; props to the exponent team for that! Still needed for iOS though :-)

@facebook facebook locked as resolved and limited conversation to collaborators Jul 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

9 participants