Align USE_FRAMEWORKS usage between RNTester and the Template #35790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff apply to RNTester the same logic we have in the template to control the `use_framework!` setting This is a preliminary change to solve the `use_frameworks!` problems in the New Architecture for both the Template and RNTester. ## Changelog: [iOS][Changed] - Align RNTester usage of the USE_FRAMEWORKS flag to the template Reviewed By: cortinico Differential Revision: D42387701 fbshipit-source-id: db6accade6e4c45e16af20565c4b483164387edb
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42387701 |
Base commit: 44cb07b |
|
This pull request has been merged in 3367b6a. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…k#35790) Summary: Pull Request resolved: facebook#35790 This diff apply to RNTester the same logic we have in the template to control the `use_framework!` setting This is a preliminary change to solve the `use_frameworks!` problems in the New Architecture for both the Template and RNTester. ## Changelog: [iOS][Changed] - Align RNTester usage of the USE_FRAMEWORKS flag to the template Reviewed By: cortinico, dmytrorykun Differential Revision: D42387701 fbshipit-source-id: 28baf5a65b727269d55382de286a17de30e8895b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff apply to RNTester the same logic we have in the template to control the
use_framework!settingThis is a preliminary change to solve the
use_frameworks!problems in the New Architecture for both the Template and RNTester.Changelog:
[iOS][Changed] - Align RNTester usage of the USE_FRAMEWORKS flag to the template
Reviewed By: cortinico
Differential Revision: D42387701