New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix platform Typings #36650
Merged
Merged
Fix platform Typings #36650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Mar 27, 2023
hoxyq
approved these changes
Mar 27, 2023
kelset
approved these changes
Mar 27, 2023
cipolleschi
force-pushed
the
cipolleschi/fix_rn_version
branch
from
March 27, 2023 13:45
3867191
to
c698b60
Compare
cipolleschi
force-pushed
the
cipolleschi/fix_rn_version
branch
from
March 27, 2023 13:49
c698b60
to
b220efe
Compare
Base commit: 92b8981 |
cipolleschi
pushed a commit
that referenced
this pull request
Mar 27, 2023
This reverts commit aff2e93.
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
Pick Request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes some typings in the platform files. The
prerelease
value is actually a string as it can assume various values, not just numbers. We typically userc.W
, where onlyW
is a number, but for local testing, for example, we use completely different strings.Changelog
[INTERNAL] [FIXED] - Use
?string
asprerelease
type.Test Plan