Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix platform Typings #36650

Merged
merged 1 commit into from Mar 27, 2023
Merged

Fix platform Typings #36650

merged 1 commit into from Mar 27, 2023

Conversation

cipolleschi
Copy link
Contributor

Summary

This PR fixes some typings in the platform files. The prerelease value is actually a string as it can assume various values, not just numbers. We typically use rc.W, where only W is a number, but for local testing, for example, we use completely different strings.

Changelog

[INTERNAL] [FIXED] - Use ?string as prerelease type.

Test Plan

  • CircleCI must be green on the job that were failing for this problem.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 27, 2023
@cipolleschi cipolleschi merged commit aff2e93 into 0.72-stable Mar 27, 2023
3 checks passed
@cipolleschi cipolleschi deleted the cipolleschi/fix_rn_version branch March 27, 2023 14:10
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,519,141 -271
android hermes armeabi-v7a 7,834,736 -971
android hermes x86 8,998,993 +442
android hermes x86_64 8,854,061 -654
android jsc arm64-v8a 9,141,836 +1,272
android jsc armeabi-v7a 8,333,483 +706
android jsc x86 9,196,423 +2,189
android jsc x86_64 9,454,250 +940

Base commit: 92b8981
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants