Downgrade CLI to alpha.0 to get Metro working again in CI
#36654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/fix_metro_setup
branch
from
b69a17b
to
894c387
Compare
cipolleschi
force-pushed
the
cipolleschi/fix_metro_setup
branch
from
894c387
to
2c57c5e
Compare
robhogan
approved these changes
Mar 27, 2023
huntie
approved these changes
Mar 27, 2023
|
(Not just CI, but this is necessary to unbreak RC.) |
robhogan
reviewed
Mar 27, 2023
| integrity sha512-IdZj/2CZYME/iWY4cAxKBWAr/pQTfj5I2NZp8Z4+u6/KrjP2PuoMkUcb+ONvwQCLpd9R62EnuaPzXVomH43d8A== | ||
| "@react-native-community/cli-clean@^11.0.0-alpha.0": | ||
| version "11.0.0" | ||
| resolved "http://localhost:4873/@react-native-community%2fcli-clean/-/cli-clean-11.0.0.tgz#7225f8df011893de1cb740a0cad3dd2670574da5" |
There was a problem hiding this comment.
@cipolleschi - sorry, just spotted these localhost URLs in the lockfile.
That might be OK for CI if that's the Verdaccio host, but won't work for contributors. Not sure if this is related to alpha-0 being unpublished?
There was a problem hiding this comment.
Working on a follow-up PR to fix these now.
There was a problem hiding this comment.
Working on a follow-up PR to fix these now.
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the work @huntie is doing to fix the CLI-Metro situation. For the time being, this local commit should bring back CircleCI to a green state.
Changelog
[General][Fixed] - Downgrade CLI to alpha.0 to make Metro work again
Test Plan