Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOCAL] Remove license header from android/app/build.gradle #37514

Merged
merged 1 commit into from May 22, 2023

Conversation

cortinico
Copy link
Contributor

Summary:

I've looked through the upgrade helper for 0.72 and noticed that we added a license header to android/app/build.gradle which should be reverted. This is a byproduct of the monorepo work as those files were excluded from the license header linter.

The equivalent change on main is:

Changelog:

[INTERNAL] - Remove license header from android/app/build.gradle

Test Plan:

Nothing to test

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 22, 2023
@kelset kelset merged commit 5e847c4 into facebook:0.72-stable May 22, 2023
11 of 17 checks passed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,546,276 -187,096
android hermes armeabi-v7a 7,860,541 -184,013
android hermes x86 9,025,343 -198,136
android hermes x86_64 8,880,485 -194,975
android jsc arm64-v8a 9,146,237 -151,942
android jsc armeabi-v7a 8,336,272 -150,641
android jsc x86 9,199,638 -159,710
android jsc x86_64 9,457,862 -157,564

Base commit: b6d9217
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants