Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yoga][0.74] Fix archive for MacOS Catalyst #43900

Merged
merged 1 commit into from Apr 8, 2024
Merged

[Yoga][0.74] Fix archive for MacOS Catalyst #43900

merged 1 commit into from Apr 8, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Apr 5, 2024 •
edited

Summary:

Following up #41938, this PR targeting 0.74 will fix an archiving issue for the Yoga pod

Changelog:

[iOS][Fixed] - Fix Yoga archiving with static frameworks on MacOS Catalyst

Test Plan:

Tested locally and by the community

@cipolleschi cipolleschi changed the base branch from main to 0.74-stable April 5, 2024 09:39
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 5, 2024
@cipolleschi cipolleschi changed the title cipolleschi/fix yoga archive 0.74 [Yoga][0.74] Fix archive for MacOS Catalyst Apr 5, 2024
@cipolleschi cipolleschi marked this pull request as ready for review April 5, 2024 09:40
@cipolleschi cipolleschi mentioned this pull request Apr 5, 2024
Closed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,820,458 -1,098,331
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,178,721 -1,104,571
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 627bff2
Branch: main

@cortinico cortinico merged commit 0e5dc51 into 0.74-stable Apr 8, 2024
52 of 54 checks passed
This was referenced Apr 9, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
4 participants
@cipolleschi @analysis-bot @cortinico @facebook-github-bot