[0.18] Things we should cherry-pick to 0.18

[mkonicek]

Moving the release to Monday Jan 18 as there are quite a few things to get in plus we had an internal hackathon today on RN + Buck.

• Fix for TransformError: ... Cannot read property 'error' of null ([0.18-rc][packager] Packager throws error "Cannot read property 'error' of null" instead of babel errors #5191). Update: We just need to cherry-pick 5a4ee0b
• Android alert() 1dc56a6
• Android Proguard fix (5f3d08d), support split built per architecture (5f3d08d)
• Fix StyleSheet 'textAlign' for AndroidTextInput, Fix StyleSheet 'textAlign' for AndroidTextInput. Closes #2702 #4481
• 4f9086f
• 7ecb693 - This breaks iOS, see comment on Dont call npm before node is available #5156
• 5a3b272
• 180fc06
• 0065986
• Symbol polyfill: Add ES6 Symbol polyfill for compatibility with iOS 8 and Android #5294, EDIT: See discussion on the PR
• Modal: [WIP] Initial implementation of Modal on Android #5320, EDIT: See discussion on the PR

[satya164]

Should also cherry pick 4f9086f , 7ecb693

And may be this, 5a3b272 (Flow gives lots of warnings due to this, and is almost unusable, though there are other warnings too, this will at least decrease them)

Also in https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/ReactActivity.java , it now extends Activity instead of FragmentActivity. It will be difficult for third-party libs that require the use of FragmentActivity (refer #4827 (comment)). It might also break the DialogModule as the commit message says that it requires FragmentActivity - 3a3af8a

PR here - #5206

[ide]

180fc06 Fixes iOS 7

[mkonicek]

Thanks a lot guys! Commented on the PR #5206.

[jsierles]

Also should get this once it's merged. A number of people have run into it including myself:

#4481

[mkonicek]

Thanks @jsierles, added.

[skevy]

0065986

and

#5294

[mkonicek]

Thanks @skevy! Commented on the PR, thanks for the fix!

[Ehesp]

1843709

This would be awesome too.

[tomauty]

^ yes please

[mkonicek]

The Android Picker (1843709) is not 100% ready yet, we want to clean up the API to make it more consistent with iOS.

[mkonicek]

Releasing now. I haven't been able to cherry-pick the fix for react-native-xcode.sh (7ecb693), see comment on #5156.

The Android textAlign fix (#4481) requires a change to internal tests. We're now figuring out a way to run the Android integration tests both internally and on CircleCI and then open sourcing all of them so Android PRs can be merged more easily.

[satya164]

Closing as 0.18 is already released.