Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example code in "Sending events to JavaScript" #530

Closed
wants to merge 3 commits into from

Conversation

phamhieu
Copy link

We should call "sendDeviceEventWithName" instead of "sendAppEventWithName" in

- (void)calendarEventReminderReceived:(NSNotification *)notification
{
  NSString *eventName = notification.userInfo[@"name"];
  [self.bridge.eventDispatcher sendAppEventWithName:@"EventReminder"
                                               body:@{@"name": eventName}];
}

@vjeux
Copy link
Contributor

vjeux commented Apr 3, 2015

@sahrens can you look at this?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2015
@brentvatne
Copy link
Collaborator

@sahrens @vjeux - this is not necessary if we merge #918

@sahrens
Copy link
Contributor

sahrens commented May 11, 2015

Yeah, closing in favor of #918.

@sahrens sahrens closed this May 11, 2015
jfrolich pushed a commit to jfrolich/react-native that referenced this pull request Apr 22, 2020
To avoid brutal breaking change, I used `[@deprecated]` for pt. We can remove it  a bit later, because we know some people rely on this bindings already :)

Closes facebook#530
ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
acoates-ms pushed a commit to acoates-ms/react-native that referenced this pull request Aug 18, 2020
* Create feature-request template

* Rename feature-request.md to feature_request.md

* Create module_request.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants