Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANDROID] Default app release version broken since 0.19 #5818

Closed
thedgbrt opened this issue Feb 8, 2016 · 4 comments
Closed

[ANDROID] Default app release version broken since 0.19 #5818

thedgbrt opened this issue Feb 8, 2016 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@thedgbrt
Copy link

thedgbrt commented Feb 8, 2016

Hey guys,
After starting a new project with react-native init, the default app crashes on Android when installed as a signed APK. This doesn't happen on 0.18. After digging through the changes, the cause is this line :
def enableProguardInReleaseBuilds = true in this file

Setting it to true fixes the problem.

@thedgbrt thedgbrt changed the title [ANDROID] Default app broken since 0.19 [ANDROID] Default app release version broken since 0.19 Feb 8, 2016
@facebook-github-bot
Copy link
Contributor

Hey dagobertrenouf, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!

@b12k
Copy link

b12k commented Feb 8, 2016

This is a bug in 0.19 React-Native release (closed by: #5717).
Had same issued.
Fixed it with:
#5655 (comment)

Change your_app_path/android/app/proguard-rules.pro:
From (lines 45-46):

-keepclassmembers class *  { @com.facebook.react.uimanager.ReactProp <methods>; }
-keepclassmembers class *  { @com.facebook.react.uimanager.ReactPropGroup <methods>; }

To:

-keepclassmembers class *  { @com.facebook.react.uimanager.annotations.ReactProp <methods>; }
-keepclassmembers class *  { @com.facebook.react.uimanager.annotations.ReactPropGroup <methods>; }

@mkonicek
Copy link
Contributor

Thanks for answering this @b12k.

@christopherdro If an issue is answered feel free to close :)

@mkonicek
Copy link
Contributor

Sorry about the bug in the first place! Fixed now.

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants