Introduce disabling for Touchable* elements #5931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
cc @mkonicek |
|
@Kureev updated the pull request. |
|
@facebook-github-bot liar! |
| @@ -41,6 +41,10 @@ var TouchableWithoutFeedback = React.createClass({ | |||
| React.PropTypes.arrayOf(React.PropTypes.oneOf(View.AccessibilityTraits)), | |||
| ]), | |||
| /** | |||
| * Disable all component interactions if value is true | |||
There was a problem hiding this comment.
nit: if the value is true / If true, disable all interactions for this component.
|
Does this work also for Do they still animate if you set disabled to true? Do you want them to animate? Should You could try this in the |
|
Will do! |
|
👍 thank you. |
Kureev
force-pushed
the
feature/disable-touchable-highlight
branch
from
76bbd1c
to
bb304f9
Compare
|
@mkonicek I've added a "Disabled Touchable*" example to UIExplorer:
Yes
No
No, it should behave like a usual text when disabled
No |
|
@Kureev updated the pull request. |
| animationVelocity={0} | ||
| underlayColor="rgb(210, 230, 255)" | ||
| style={[styles.row, styles.block]} | ||
| onPress={() => console.log('custom THW text - hightlight')}> |
|
OK, let's shipit. The test plan doesn't show whether this disables animations for @facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
|
I'll make a 2 follow-up PRs:
Thanks for merging this one in, @mkonicek |
ghost
pushed a commit
that referenced
this pull request
Feb 24, 2016
Summary:Follow-up PR for fixing typos in #5931 **Test plan (required)** This PR contains only copy changes, so no additional testing is required. **Code formatting** This PR code style match the desired [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). cc mkonicek Closes #6122 Differential Revision: D2970751 Pulled By: javache fb-gh-sync-id: 007ab6e732e88f39c7f392f00b2bd668ebb4d7d5 shipit-source-id: 007ab6e732e88f39c7f392f00b2bd668ebb4d7d5
ghost
pushed a commit
that referenced
this pull request
Feb 24, 2016
Summary:Follow-up PR for #5931: Adding missing `TouchableNativeFeedback` example. **Test plan** - Run UIExplorer on iOS and Android devices [Android] - Go to Touchable* examples and scroll down to the `Disabled Touchable*` section. There are two new buttons there: `Enabled TouchableNativeFeedback` and `Disabled TouchableNativeFeedback`. Buttons should behave according their titles. [iOS] - Go to Touchable* examples and scroll down to the `Disabled Touchable*` section. As far as `TouchableNativeFeedback` is supported on Android only, you **wouldn't see** any new buttons there **Code formatting** This PR code style match the desired [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). cc mkonicek Closes #6123 Differential Revision: D2971021 fb-gh-sync-id: 3be18bda15b5b495caaf9e4444fd0deb47a44839 shipit-source-id: 3be18bda15b5b495caaf9e4444fd0deb47a44839
|
💯 Awesome, thanks @Kureev! |
|
haha, you're welcome, @mkonicek 😉 |
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary:Introduce a `disabled` property for Touchable* components. Fix facebook#2103 Closes facebook#5931 Differential Revision: D2969790 Pulled By: mkonicek fb-gh-sync-id: 570a4ff882219f52f2d2ebef3eb73b1df50a0877 shipit-source-id: 570a4ff882219f52f2d2ebef3eb73b1df50a0877
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary:Follow-up PR for fixing typos in facebook#5931 **Test plan (required)** This PR contains only copy changes, so no additional testing is required. **Code formatting** This PR code style match the desired [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). cc mkonicek Closes facebook#6122 Differential Revision: D2970751 Pulled By: javache fb-gh-sync-id: 007ab6e732e88f39c7f392f00b2bd668ebb4d7d5 shipit-source-id: 007ab6e732e88f39c7f392f00b2bd668ebb4d7d5
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary:Follow-up PR for facebook#5931: Adding missing `TouchableNativeFeedback` example. **Test plan** - Run UIExplorer on iOS and Android devices [Android] - Go to Touchable* examples and scroll down to the `Disabled Touchable*` section. There are two new buttons there: `Enabled TouchableNativeFeedback` and `Disabled TouchableNativeFeedback`. Buttons should behave according their titles. [iOS] - Go to Touchable* examples and scroll down to the `Disabled Touchable*` section. As far as `TouchableNativeFeedback` is supported on Android only, you **wouldn't see** any new buttons there **Code formatting** This PR code style match the desired [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). cc mkonicek Closes facebook#6123 Differential Revision: D2971021 fb-gh-sync-id: 3be18bda15b5b495caaf9e4444fd0deb47a44839 shipit-source-id: 3be18bda15b5b495caaf9e4444fd0deb47a44839
rozele
referenced
this pull request
in microsoft/react-native-windows
May 25, 2016
Summary:Follow-up PR for fixing typos in #5931 **Test plan (required)** This PR contains only copy changes, so no additional testing is required. **Code formatting** This PR code style match the desired [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). cc mkonicek Closes facebook/react-native#6122 Differential Revision: D2970751 Pulled By: javache fb-gh-sync-id: 007ab6e732e88f39c7f392f00b2bd668ebb4d7d5 shipit-source-id: 007ab6e732e88f39c7f392f00b2bd668ebb4d7d5
rozele
referenced
this pull request
in microsoft/react-native-windows
May 25, 2016
Summary:Follow-up PR for #5931: Adding missing `TouchableNativeFeedback` example. **Test plan** - Run UIExplorer on iOS and Android devices [Android] - Go to Touchable* examples and scroll down to the `Disabled Touchable*` section. There are two new buttons there: `Enabled TouchableNativeFeedback` and `Disabled TouchableNativeFeedback`. Buttons should behave according their titles. [iOS] - Go to Touchable* examples and scroll down to the `Disabled Touchable*` section. As far as `TouchableNativeFeedback` is supported on Android only, you **wouldn't see** any new buttons there **Code formatting** This PR code style match the desired [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). cc mkonicek Closes facebook/react-native#6123 Differential Revision: D2971021 fb-gh-sync-id: 3be18bda15b5b495caaf9e4444fd0deb47a44839 shipit-source-id: 3be18bda15b5b495caaf9e4444fd0deb47a44839
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
disabledproperty for Touchable* components.Fix #2103