Modal shouldn't cover the Element inspector

[mkonicek]

When the Element inspector is shown and a <Modal> is rendered at the same time, the Modal covers the Element inspector. This shouldn't be the case :)

Experience required: JS.

[Ehesp]

The modal covers everything for me, can't even access the dev menu.

[frantic]

We've fixed this internally, should be a trivial fix in OSS. The idea is to wrap the content of the modal into <AppContainer> that provides all development level tools – inspector, yellow box, etc.

[mkonicek]

@frantic Oh cool, so the Modal effectively renders the YellowBox and the Modal's children:
https://github.com/facebook/react-native/blob/master/Libraries/ReactIOS/AppContainer.js

[mkonicek]

The modal covers everything for me, can't even access the dev menu.

@Ehesp I created a separate issue for this: #8187. The trick with AppContainer might not be enough for the dev menu being behind Modal. We might need changes in native for that one (at least on Android).

[mkonicek]

@frantic Can you explain this a bit more please? Did you mean <Modal> should render an <AppContainer> by default?

[BilalBudhani]

@frantic I'm looking into this issue as well. It would be great if you can explain a bit more.

[aakashsigdel]

@mkonicek as mentioned by @frantic, wrapping the contains of the modal in AppContainer does seem to solve the problem. Could you please tell me what is the status on this issue? Should I open a PR for this?

[satya164]

@aakashsigdel Yeah, would be cool if you can send a PR.

[aakashsigdel]

@satya164 I tried to include the master branch as dependency in my project, but it fails with "Requiring unknown module "react/lib/ReactPropTypesSecret".

I followed the guide from the docs: Building React Native from source
https://facebook.github.io/react-native/docs/android-building-from-source.html

Is there something I am missing?

[christopherdro]

Fixed via 05de4db