Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing closing brace for fetchCompletionHandler in PushNotificationIOS Docs at https://facebook.github.io/react-native/docs/pushnotificationios.html #11150

Closed
Brisdo opened this issue Nov 26, 2016 · 1 comment
Closed

Missing closing brace for fetchCompletionHandler in PushNotificationIOS Docs at https://facebook.github.io/react-native/docs/pushnotificationios.html #11150

Brisdo opened this issue Nov 26, 2016 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@Brisdo
Copy link

Brisdo commented Nov 26, 2016

Description

The PushNotificationIOS Docs is missing closing brace for fetchCompletionHandler.

Reproduction

Try to compile using the current Docs:

fetchCompletionHandler:(void (^)(UIBackgroundFetchResult))completionHandler {
   {
      [RCTPushNotificationManager didReceiveRemoteNotification:userInfo fetchCompletionHandler:completionHandler];
   }
   // Optionally implement this method over the previous to receive remote notifications. However

Solution

Change Docs to read:

fetchCompletionHandler:(void (^)(UIBackgroundFetchResult))completionHandler {
   {
      [RCTPushNotificationManager didReceiveRemoteNotification:userInfo fetchCompletionHandler:completionHandler];
   }
}
   // Optionally implement this method over the previous to receive remote notifications. However
@mkonicek
Copy link
Contributor

Thanks for finding this! Can you send a pull request to add the brace please? :)

damusnet added a commit to damusnet/react-native that referenced this issue Dec 1, 2016
@damusnet
Add missing closing brace in docs
2f2f1a2 
fixes facebook#11150
@damusnet damusnet mentioned this issue Dec 1, 2016
Closed
robclouth pushed a commit to robclouth/react-native that referenced this issue Dec 7, 2016
@damusnet @robclouth
Add missing closing brace in docs
36ecc03 
Summary:
This is a minor documentation fix

fixes facebook#11150
Closes facebook#11253

Differential Revision: D4268276

fbshipit-source-id: 67c8f9b4c77a2c781c09376bf4fc15a61b3db490
mkonicek pushed a commit that referenced this issue Dec 12, 2016
@damusnet
Add missing closing brace in docs
6152fff 
Summary:
This is a minor documentation fix

fixes #11150
Closes #11253

Differential Revision: D4268276

fbshipit-source-id: 67c8f9b4c77a2c781c09376bf4fc15a61b3db490
@tristanbbq tristanbbq mentioned this issue Dec 15, 2016
Closed
tristanbbq pushed a commit to tristanbbq/react-native that referenced this issue Dec 15, 2016
@damusnet @tristanbbq
Add missing closing brace in docs
668a39b 
Summary:
This is a minor documentation fix

fixes facebook#11150
Closes facebook#11253

Differential Revision: D4268276

fbshipit-source-id: 67c8f9b4c77a2c781c09376bf4fc15a61b3db490
@tristanbbq tristanbbq mentioned this issue Dec 15, 2016
Closed
janicduplessis pushed a commit that referenced this issue Dec 15, 2016
@damusnet @janicduplessis
Add missing closing brace in docs
480a038 
Summary:
This is a minor documentation fix

fixes #11150
Closes #11253

Differential Revision: D4268276

fbshipit-source-id: 67c8f9b4c77a2c781c09376bf4fc15a61b3db490
DanielMSchmidt pushed a commit to DanielMSchmidt/react-native that referenced this issue Jan 4, 2017
@damusnet @DanielMSchmidt
Add missing closing brace in docs
0628e7f 
Summary:
This is a minor documentation fix

fixes facebook#11150
Closes facebook#11253

Differential Revision: D4268276

fbshipit-source-id: 67c8f9b4c77a2c781c09376bf4fc15a61b3db490
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing closing brace in docs damusnet/react-native
3 participants
@mkonicek @Brisdo @react-native-bot