Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HelloWorld still references CSSLayout instead of Yoga #11605

Closed
ptomasroos opened this issue Dec 23, 2016 · 0 comments
Closed

HelloWorld still references CSSLayout instead of Yoga #11605

ptomasroos opened this issue Dec 23, 2016 · 0 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ptomasroos
Copy link
Contributor

https://github.com/facebook/react-native/blob/59407f36608f52d4402d742d916f78acd3ca7152/local-cli/templates/HelloWorld/ios/HelloWorld.xcodeproj/project.pbxproj

		3DAD3EA41DF850E9000B6D8A /* PBXContainerItemProxy */ = {
			isa = PBXContainerItemProxy;
			containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */;
			proxyType = 2;
			remoteGlobalIDString = 3D3C059A1DE3340900C268FA;
			remoteInfo = CSSLayout;
		};
		3DAD3EA61DF850E9000B6D8A /* PBXContainerItemProxy */ = {
			isa = PBXContainerItemProxy;
			containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */;
			proxyType = 2;
			remoteGlobalIDString = 3D3C06751DE3340C00C268FA;
			remoteInfo = "CSSLayout-tvOS";
		};

Pretty sure we should be referring to Yoga these days as this file is the only one containing CSSLayout references these days.
@ptomasroos ptomasroos mentioned this issue Dec 23, 2016
Closed
ide pushed a commit that referenced this issue Dec 29, 2016
@ptomasroos @ide
Updated imports to libyoga*.a in HelloWorld
2debfa1 
Summary:
Fixes #11605

HelloWorld refers to CSSLayout even thought master has moved on and the library is now called Yoga.
Closes #11606

Differential Revision: D4365469

fbshipit-source-id: e0eaac400449f0ba767bf98f3bd8e8185fb6fd12
nicktate pushed a commit to nicktate/react-native that referenced this issue Dec 30, 2016
@ptomasroos @nicktate
Updated imports to libyoga*.a in HelloWorld
032f268 
Summary:
Fixes facebook#11605

HelloWorld refers to CSSLayout even thought master has moved on and the library is now called Yoga.
Closes facebook#11606

Differential Revision: D4365469

fbshipit-source-id: e0eaac400449f0ba767bf98f3bd8e8185fb6fd12
DanielMSchmidt pushed a commit to DanielMSchmidt/react-native that referenced this issue Jan 4, 2017
@ptomasroos @DanielMSchmidt
Updated imports to libyoga*.a in HelloWorld
4e8f8ab 
Summary:
Fixes facebook#11605

HelloWorld refers to CSSLayout even thought master has moved on and the library is now called Yoga.
Closes facebook#11606

Differential Revision: D4365469

fbshipit-source-id: e0eaac400449f0ba767bf98f3bd8e8185fb6fd12
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomasroos @react-native-bot