Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choco JRE should be added to getting-started #12780

Closed
thebetterjort opened this issue Mar 8, 2017 · 2 comments
Closed

choco JRE should be added to getting-started #12780

thebetterjort opened this issue Mar 8, 2017 · 2 comments
Labels
Platform: Windows Building on Windows. Resolution: Locked This issue was locked by the bot.

Comments

@thebetterjort
Copy link

thebetterjort commented Mar 8, 2017 •
edited

Should this choco command be added to the list of choco commands for the documentation (windows) ?
https://facebook.github.io/react-native/docs/getting-started.html

choco install jdk8

I needed to install this. FYI.
@ide ide added Documentation Platform: Windows Building on Windows. labels Mar 8, 2017
@hramos
Copy link
Contributor

hramos commented Mar 10, 2017

The bare minimum is jdk7, but jdk8 is needed if you will be running tests or compiling from source. We can add this, since I don't think the JDK is bundled with Windows.

@hramos hramos mentioned this issue Mar 10, 2017
Closed
facebook-github-bot pushed a commit that referenced this issue Mar 10, 2017
@hramos @facebook-github-bot
Documentation updates
30bf039 
Summary:
Tackling a handful of docs issues:

- #12780
- #11227
- #2819
Closes #12867

Differential Revision: D4691083

Pulled By: hramos

fbshipit-source-id: 9115315f2d6132e975901c9a0b784e9d41eeb49e
@hramos hramos added the Icebox label Jul 25, 2017
@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos closed this as completed Jul 25, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Platform: Windows Building on Windows. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hramos @ide @thebetterjort @react-native-bot