RCTAdSupport uses advertisingidentifier which triggers Apple's automated detection upon submit #1303
Labels
Resolution: Locked
This issue was locked by the bot.
Comments
|
Perhaps obfuscating the usage with NSClassFromString could be a workaround as not to trigger the automated detection. |
|
The best fix is for the sample project to not link in AdSupport. Only apps that track users across different apps made by different companies require it. |
|
Apple has made it pretty clear if you're not serving ads don't think about using the advertisingIdentifier. IIRC they'll detect the call at runtime so no matter how you obfuscate the message, if in the end you're calling advertisingIdentifier they'll flag it. |
|
I think the idea is that the obfuscation will prevent rejected apps from people that are not using the identifier. However the app will still then be linked to the AdSupport.framework which may raise some eyebrows. |
dsibiski
added a commit
to rnplay/rnplay-native-deprecated
that referenced
this issue
Jun 5, 2015
- Not needed right now and will cause issues with submission to Apple Reference: facebook/react-native#1303
dsibiski
added a commit
to rnplay/rnplay-native-deprecated
that referenced
this issue
Jun 5, 2015
- Not needed right now and will cause issues with submission to Apple Reference: facebook/react-native#1303
rozele
referenced
this issue
in microsoft/react-native-windows
May 25, 2016
Summary: Many apps don't need AdSupport, especially not when people are making a sample app to learn React. Apps that do want it can link it in like any other library. Fixes #1303, see the discussion there. Closes facebook/react-native#1305 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 28, 2017
Summary: Looks like RN unlinked the RCTAdSupport module from the React project because it triggers some automatic detection from Apple. (from this thread #1303). So this includes the instructions to manually add RCTAdSupport files from node_modules. See: #12623 Closes #12657 Differential Revision: D4962321 Pulled By: hramos fbshipit-source-id: ed9aed3b4c16e72d1f9557f5c16fcdadfdd743ea
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this issue
May 7, 2017
Summary: Looks like RN unlinked the RCTAdSupport module from the React project because it triggers some automatic detection from Apple. (from this thread facebook#1303). So this includes the instructions to manually add RCTAdSupport files from node_modules. See: facebook#12623 Closes facebook#12657 Differential Revision: D4962321 Pulled By: hramos fbshipit-source-id: ed9aed3b4c16e72d1f9557f5c16fcdadfdd743ea
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I just submitted an app to the AppStore earlier today, and I had to remove the implementation of the two methods in RCTAdSupport as to not trigger Apple's automated advertisingidentifier detection (https://github.com/facebook/react-native/blob/master/Libraries/AdSupport/RCTAdSupport.m#L20). They force you to explain why you are using advertisingIdentifier if they detect it (and might reject you if you're not using ads).
Perhaps this should be in the docs, or toggled via an ifdef if you actually use ads?
(Apple about advertisingIdentifier https://developer.apple.com/news/?id=08282014a)
The text was updated successfully, but these errors were encountered: