Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccessibilityManager.setAccessibilityContentSizeMultipliers exception #14043

Closed
pietropizzi opened this issue May 18, 2017 · 4 comments
Closed

AccessibilityManager.setAccessibilityContentSizeMultipliers exception #14043

pietropizzi opened this issue May 18, 2017 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@pietropizzi
Copy link

Description

Since upgrading to React Native 0.44 (from 0.43) when calling AccessibilityManager.setAccessibilityContentSizeMultipliers I get this red screen

simulator screen shot 18 may 2017 13 58 48

Reproduction Steps and Sample Code

We call this method in our root component's componentDidMount and it worked just fine so far. I created a snack https://snack.expo.io/ryOh1Migb but can not reproduce exception there. I am not sure which version of react-native expo v16 uses though.

Additional Information

  • React Native version: 0.44.0
  • Platform: iOS
  • Development Operating System: macOS
  • Dev tools: Xcode 8.3.2
@ghost
Copy link

ghost commented Jun 1, 2017

Looks like the implementation of RCTDeviceInfo.m broke this, as the RCTAccessibilityManagerDidUpdateMultiplierNotification notification is being posted on the JS thread rather than the main thread, breaking the assertion in RCTExportedDimensions.

This is effectively blocking upgrades to RN 0.44 for anyone setting custom accessibility content size multipliers. Is this being looked at for RN 0.45?

ghost referenced this issue Jun 9, 2017
@ashwinb @facebook-github-bot
Introduce DeviceInfo as a new native module
95c1926 
Summary:
The `UIManager` already has a lot of responsibilities and is deeply
tied with React Native's view architecture. This diff separates out a
`DeviceInfo` native module to provide information about screen dimensions and
font scale, etc.

Reviewed By: fkgozali

Differential Revision: D4713834

fbshipit-source-id: f2ee93acf876a4221c29a8c731f5abeffbb97974
@mmmulani
Copy link
Contributor

just put a fix in for this, let me know if it's still breaking for you

@fkgozali
Copy link
Contributor

i.e. 112e376

@ghost
Copy link

ghost commented Jun 21, 2017

LGTM, thanks! 👍

@facebook facebook locked as resolved and limited conversation to collaborators Jun 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mmmulani @pietropizzi @fkgozali @react-native-bot