Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to support platform specific ViewPropTypes #15173

Closed
rozele opened this issue Jul 24, 2017 · 0 comments
Closed

Add hook to support platform specific ViewPropTypes #15173

rozele opened this issue Jul 24, 2017 · 0 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@rozele
Copy link
Contributor

rozele commented Jul 24, 2017

Is this a bug report?

Yes.

Have you read the Bugs section of the How to Contribute guide?

Yes.

Environment

  1. react-native -v: 1000.0.0 (master)
  2. node -v: 8.1.2
  3. npm -v: 5.0.3
  4. yarn --version: N/A

Then, specify:

  • Target Platform: Windows (react-native-windows)
  • Development Operating System: Windows 10
  • Build tools: Visual Studio

Steps to Reproduce

(Write your steps here:)

  1. Add new native prop to RCTView native view manager in react-native-windows
  2. Add prop to <View/> instance in JavaScript app / bundle
  3. Exception that new prop is not a valid prop type (because it's not declared in ViewPropTypes)

Expected Behavior

I expect a way to extend ViewPropTypes for platform plugins to react-native.

Actual Behavior

There is no way to extend the ViewPropTypes for platform plugins.

I'll be filing a PR shortly.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants