Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Website] Add "- React Native" to page titles #15659

Closed
sophiebits opened this issue Aug 25, 2017 · 4 comments
Closed

[Website] Add "- React Native" to page titles #15659

sophiebits opened this issue Aug 25, 2017 · 4 comments
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.

Comments

@sophiebits
Copy link
Contributor

If you search on Google for accessibility, the React Native page just says "Accessibility - Facebook Code":

image

This is because the document title is just "Accessibility". Let's add "- React Native" to all our page titles (except the homepage itself, which already has it) which will make the results easier to distinguish.
@sophiebits sophiebits added the Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Aug 25, 2017
@gabrielglvr
Copy link
Contributor

I want to work on this but i thing that i'm not understand as well, is just about change the doc .md file title or .html pages? I'm not found the html pages in react-native repository.

@sophiebits
Copy link
Contributor Author

This is just about changing the .html files, which are autogenerated from .md. Try looking in website/layout/ for clues.

@gabrielglvr gabrielglvr mentioned this issue Aug 30, 2017
Closed
@gabrielglvr
Copy link
Contributor

gabrielglvr commented Aug 30, 2017 •
edited

Thank you for help ! I made a pr =D

facebook-github-bot pushed a commit that referenced this issue Aug 30, 2017
@gabrielglvr @facebook-github-bot
Add "- React Native" to all pages title in doc section
2b86aba 
Summary:
<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->
Changing all pages in doc to have title " - React Native", which will make the results easier to distinguish like suggested in issue #15659.

I'm not shure how to write a test to this but if you open any page in doc you can see the page title has changed when the title is passed to Site component.
Closes #15714

Differential Revision: D5739971

Pulled By: TheSavior

fbshipit-source-id: ba9b5ea83fe5c502653972262eb993a24941a62e
@TheSavior
Copy link
Member

The fix landed. Thanks!

@facebook facebook locked as resolved and limited conversation to collaborators Aug 31, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sophiebits @TheSavior @gabrielglvr @react-native-bot