Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show download progress bar during 'react-native init' #3771

Closed
mkonicek opened this issue Oct 29, 2015 · 3 comments · Fixed by #4835
Closed

Show download progress bar during 'react-native init' #3771

mkonicek opened this issue Oct 29, 2015 · 3 comments · Fixed by #4835
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.

Comments

@mkonicek
Copy link
Contributor

'react-native init' spends almost all its time in 'npm install':
https://github.com/facebook/react-native/blob/master/react-native-cli/index.js#L191

It would be cool to show a progress bar during the download.

A quick Google search returns: npm/npm#6911
@mkonicek mkonicek added the Help Wanted :octocat: Issues ideal for external contributors. label Oct 29, 2015
@mkonicek mkonicek changed the title Progress bar during 'react-native init' Show download progress bar during 'react-native init' Oct 29, 2015
@udnisap
Copy link
Contributor

udnisap commented Dec 15, 2015

It is there in node v5 or npm 3.3.6 If we use spawn instead of exec we can show it with a pipe like we do in https://github.com/facebook/react-native/blob/master/react-native-cli/index.js#L207
in previous versions of node it would be bit tricky.

@christopherdro
Copy link
Contributor

Nice one @udnisap! Just tested it out.
Could you submit a PR with this change?

udnisap added a commit to udnisap/react-native that referenced this issue Dec 17, 2015
@udnisap
npm progress shown on react init
5da0e13 
fixes facebook#3771 for npm 5 and upwards
@udnisap udnisap mentioned this issue Dec 17, 2015
Merged
@mkonicek
Copy link
Contributor Author

mkonicek commented Jan 5, 2016

Thanks for adding it! I've put this behavior behind a --debug flag, realized showing it by default was not a good experience: 6af7ae5

--verbose still works as before.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

npm progress shown on react init udnisap/react-native
4 participants
@udnisap @mkonicek @christopherdro @react-native-bot