Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is possible to break the docs site and have it still publish #443

Closed
glenjamin opened this issue Mar 29, 2015 · 2 comments
Closed

It is possible to break the docs site and have it still publish #443

glenjamin opened this issue Mar 29, 2015 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@glenjamin
Copy link

When #433 was merged, the build ran and published an updated docs site, but every page ended up displaying a stack trace.

This should probably get caught during the travis build and not publish.
@glenjamin
Copy link
Author

2015-03-29 17 57 46

here's what it looked like.

@brentvatne
Copy link
Collaborator

I believe that this is protected against now, thanks for the issue @glenjamin!

facebook-github-bot pushed a commit that referenced this issue Mar 3, 2017
@woehrl01 @facebook-github-bot
Mark all children as dirty if display changes
495fb54 
Summary:
If we set ```display:none``` all children are set with layout sizes/values of 0. We need do mark all those children as dirty to force a relayout if we toggle the display on a higher parent node. This fixes #443
Closes facebook/yoga#448

Reviewed By: astreet

Differential Revision: D4642273

Pulled By: emilsjolander

fbshipit-source-id: dfdb920e2049952bd6c7f48cfa53b1448e1f3e8f
@facebook facebook locked as resolved and limited conversation to collaborators May 31, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brentvatne @glenjamin @react-native-bot