Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NavigationExperimental] BackAction for nested StackReducers #6963

Closed
arbesfeld opened this issue Apr 13, 2016 · 1 comment
Closed

[NavigationExperimental] BackAction for nested StackReducers #6963

arbesfeld opened this issue Apr 13, 2016 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@arbesfeld
Copy link
Contributor

The outermost NavigationStackReducer will always handle a back action: https://github.com/facebook/react-native/blob/master/Libraries/NavigationExperimental/Reducer/NavigationStackReducer.js#L76

One possible solution would be to add a "key" to the back action and check for this key in the reducer.

Thoughts @ericvicenti?
@ericvicenti
Copy link
Contributor

Thanks for raising this issue. I think the current behavior is a bug, and we always want to allow the inner reducer to handle a back action first. Can you submit a PR to re-arrange the reducer and fix this? Also cc @hedgerwang

@arbesfeld arbesfeld mentioned this issue Apr 14, 2016
Closed
ghost pushed a commit that referenced this issue Apr 15, 2016
@arbesfeld
Let inner nested stack reducers handle back actions first
ef8e688 
Summary:Fix for #6963
Closes #6982

Differential Revision: D3180164

Pulled By: ericvicenti

fb-gh-sync-id: 234d3027097ae032ba0e24470adb3a5ebf07e351
fbshipit-source-id: 234d3027097ae032ba0e24470adb3a5ebf07e351
@arbesfeld arbesfeld mentioned this issue Apr 19, 2016
Closed
@domchristie domchristie mentioned this issue Jun 2, 2016
Open
zebulgar pushed a commit to nightingale/react-native that referenced this issue Jun 18, 2016
@arbesfeld @zebulgar
Let inner nested stack reducers handle back actions first
8a66315 
Summary:Fix for facebook#6963
Closes facebook#6982

Differential Revision: D3180164

Pulled By: ericvicenti

fb-gh-sync-id: 234d3027097ae032ba0e24470adb3a5ebf07e351
fbshipit-source-id: 234d3027097ae032ba0e24470adb3a5ebf07e351
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ericvicenti @arbesfeld @facebook-github-bot @react-native-bot