Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong reference in local-cli/util/Config.js #7670

Closed
jwyld opened this issue May 21, 2016 · 1 comment
Closed

wrong reference in local-cli/util/Config.js #7670

jwyld opened this issue May 21, 2016 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jwyld
Copy link
Contributor

jwyld commented May 21, 2016

local-cli/util/Config.js:36 should be referencing "${cwd}" instead of "${__dirname}" for the failure, since this object is attempting to walk a directory structure provided by cwd and not __dirname.
@jwyld jwyld mentioned this issue May 21, 2016
Closed
ghost pushed a commit that referenced this issue May 26, 2016
Correctly reference cwd instead of __dirname
af149b3 
Summary:
This is for issue #7670.  I consider this a typo, but maybe you don't.

In order to see the problem, you need to have the packager search for the configuration in a place that doesn't have one and the default configuration can't be provided.  It's likely that no one is doing this and also why this probably wasn't seen.
Closes #7671

Differential Revision: D3350412

fbshipit-source-id: 5f9b520f7d5cbc749e2b898e7bbf2cd84d81ace0
samerce pushed a commit to iodine/react-native that referenced this issue Aug 23, 2016
@samerce
Correctly reference cwd instead of __dirname
da82121 
Summary:
This is for issue facebook#7670.  I consider this a typo, but maybe you don't.

In order to see the problem, you need to have the packager search for the configuration in a place that doesn't have one and the default configuration can't be provided.  It's likely that no one is doing this and also why this probably wasn't seen.
Closes facebook#7671

Differential Revision: D3350412

fbshipit-source-id: 5f9b520f7d5cbc749e2b898e7bbf2cd84d81ace0
mpretty-cyro pushed a commit to HomePass/react-native that referenced this issue Aug 25, 2016
Correctly reference cwd instead of __dirname
99983b7 
Summary:
This is for issue facebook#7670.  I consider this a typo, but maybe you don't.

In order to see the problem, you need to have the packager search for the configuration in a place that doesn't have one and the default configuration can't be provided.  It's likely that no one is doing this and also why this probably wasn't seen.
Closes facebook#7671

Differential Revision: D3350412

fbshipit-source-id: 5f9b520f7d5cbc749e2b898e7bbf2cd84d81ace0
@lacker
Copy link
Contributor

lacker commented Oct 26, 2016

Look like you solved this - thanks!

@lacker lacker closed this as completed Oct 26, 2016
@facebook facebook locked as resolved and limited conversation to collaborators Jul 19, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lacker @jwyld @react-native-bot