Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NavigationExperimental] Migrate NavigationCardStack to NavigationTransitioner #8262

Closed
ericvicenti opened this issue Jun 20, 2016 · 3 comments
Closed

[NavigationExperimental] Migrate NavigationCardStack to NavigationTransitioner #8262

ericvicenti opened this issue Jun 20, 2016 · 3 comments
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.

Comments

@ericvicenti
Copy link
Contributor

Currently NavigationCardStack depends on NavigationAnimatedView, which we plan to deprecate.

This is one of the final steps we need to take before we can rename NavigationExperimental to Navigation
@ericvicenti ericvicenti mentioned this issue Jun 20, 2016
Closed
@ericvicenti ericvicenti added the Help Wanted :octocat: Issues ideal for external contributors. label Jun 20, 2016
@jmurzy
Copy link
Contributor

jmurzy commented Jun 20, 2016

I'll take a stab at this shortly.

🍺

jmurzy added a commit to jmurzy/react-native that referenced this issue Jun 21, 2016
@jmurzy
Migrate NavigationCardStack to NavigationTransitioner
e040531 
Closes facebook#8262
jmurzy added a commit to jmurzy/react-native that referenced this issue Jun 21, 2016
@jmurzy
Kill NavigationAnimatedView
4c8e8cc 
NavigationAnimatedView is deprecated. Use NavigationTransitioner

Related to facebook#8262, facebook#8189
@jmurzy jmurzy mentioned this issue Jun 21, 2016
Closed
jmurzy added a commit to jmurzy/react-native that referenced this issue Jun 21, 2016
@jmurzy
Migrate NavigationCardStack to NavigationTransitioner
05cc24c 
Closes facebook#8262
jmurzy added a commit to jmurzy/react-native that referenced this issue Jun 21, 2016
@jmurzy
Kill NavigationAnimatedView
800d74b 
NavigationAnimatedView is deprecated. Use NavigationTransitioner

Related to facebook#8262, facebook#8189
jmurzy added a commit to jmurzy/react-native that referenced this issue Jun 21, 2016
@jmurzy
Kill NavigationAnimatedView
6bdd08d 
NavigationAnimatedView is deprecated. Use NavigationTransitioner

Related to facebook#8262, facebook#8189
@jmurzy jmurzy mentioned this issue Jun 21, 2016
Closed
ghost pushed a commit that referenced this issue Jun 21, 2016
@jmurzy
Migrate NavigationCardStack
47a7289 
Summary:
As discussed in #8262.
Closes #8268

Reviewed By: hedgerwang

Differential Revision: D3462059

Pulled By: ericvicenti

fbshipit-source-id: 1f48db3a15668e5a1122b7dcb244bd4352acf9a9
ghost pushed a commit that referenced this issue Jun 21, 2016
@jmurzy
Kill NavigationAnimatedView
8ce7ad4 
Summary:
NavigationAnimatedView is deprecated. Use NavigationTransitioner.

As discussed in #8262, #8189.
Closes #8269

Reviewed By: hedgerwang

Differential Revision: D3462087

Pulled By: ericvicenti

fbshipit-source-id: 6d7504cb8533f12a3610d34ef5b35edcf79fd5b7
@satya164
Copy link
Contributor

Closing since this is done.

@jr-k
Copy link
Contributor

jr-k commented Jul 12, 2016

Still called NavigationExperimental :v

samerce pushed a commit to iodine/react-native that referenced this issue Aug 23, 2016
@jmurzy @samerce
Migrate NavigationCardStack
52ba84c 
Summary:
As discussed in facebook#8262.
Closes facebook#8268

Reviewed By: hedgerwang

Differential Revision: D3462059

Pulled By: ericvicenti

fbshipit-source-id: 1f48db3a15668e5a1122b7dcb244bd4352acf9a9
samerce pushed a commit to iodine/react-native that referenced this issue Aug 23, 2016
@jmurzy @samerce
Kill NavigationAnimatedView
335ac3c 
Summary:
NavigationAnimatedView is deprecated. Use NavigationTransitioner.

As discussed in facebook#8262, facebook#8189.
Closes facebook#8269

Reviewed By: hedgerwang

Differential Revision: D3462087

Pulled By: ericvicenti

fbshipit-source-id: 6d7504cb8533f12a3610d34ef5b35edcf79fd5b7
mpretty-cyro pushed a commit to HomePass/react-native that referenced this issue Aug 25, 2016
@jmurzy
Migrate NavigationCardStack
c0ea069 
Summary:
As discussed in facebook#8262.
Closes facebook#8268

Reviewed By: hedgerwang

Differential Revision: D3462059

Pulled By: ericvicenti

fbshipit-source-id: 1f48db3a15668e5a1122b7dcb244bd4352acf9a9
mpretty-cyro pushed a commit to HomePass/react-native that referenced this issue Aug 25, 2016
@jmurzy
Kill NavigationAnimatedView
4718820 
Summary:
NavigationAnimatedView is deprecated. Use NavigationTransitioner.

As discussed in facebook#8262, facebook#8189.
Closes facebook#8269

Reviewed By: hedgerwang

Differential Revision: D3462087

Pulled By: ericvicenti

fbshipit-source-id: 6d7504cb8533f12a3610d34ef5b35edcf79fd5b7
@facebook facebook locked as resolved and limited conversation to collaborators Jun 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jmurzy @satya164 @ericvicenti @jr-k @react-native-bot