Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RNPM plugins from packages matching "react-native-*" #9168

Closed
rozele opened this issue Aug 2, 2016 · 1 comment
Closed

Add support for RNPM plugins from packages matching "react-native-*" #9168

rozele opened this issue Aug 2, 2016 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@rozele
Copy link
Contributor

rozele commented Aug 2, 2016 •
edited

RNPM has a recent commit that supports finding plugins from packages named with "react-native-*" (rnpm/rnpm@769b692). We use this feature to ship the run-windows command plugin inside the react-native-windows package (https://github.com/ReactWindows/react-native-windows/blob/master/package.json#L41). Can we apply this commit here as well?

cc @Kureev @grabbou
@rozele rozele mentioned this issue Aug 2, 2016
Merged
@grabbou
Copy link
Contributor

grabbou commented Aug 3, 2016

Already sent as a PR. Thanks for reminding us of cherry-picking changes that happened in the meantime :)

@grabbou grabbou closed this as completed Aug 3, 2016
ghost pushed a commit that referenced this issue Aug 3, 2016
@grabbou
Fixes #9168
4fce8ea 
Summary:
Imports missing commit from the rnpm master.
Closes #9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
bartolkaruza pushed a commit to immidi/react-native that referenced this issue Aug 3, 2016
@grabbou
Fixes facebook#9168
f9e3980 
Summary:
Imports missing commit from the rnpm master.
Closes facebook#9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
grabbou added a commit that referenced this issue Aug 5, 2016
@grabbou
Fixes #9168
15238fb 
Summary:
Imports missing commit from the rnpm master.
Closes #9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
samerce pushed a commit to iodine/react-native that referenced this issue Aug 23, 2016
@grabbou @samerce
Fixes facebook#9168
026ce8c 
Summary:
Imports missing commit from the rnpm master.
Closes facebook#9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
mpretty-cyro pushed a commit to HomePass/react-native that referenced this issue Aug 25, 2016
@grabbou
Fixes facebook#9168
b3eb2c6 
Summary:
Imports missing commit from the rnpm master.
Closes facebook#9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rozele @grabbou @react-native-bot