Moved RegExp declaration into function basedon PR feedback

facebook · Dec 10, 2019 · 040b28c · 040b28c
1 parent 1252a00
commit 040b28c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/react-devtools-shared/src/devtools/views/Components/SelectedElement.js b/packages/react-devtools-shared/src/devtools/views/Components/SelectedElement.js
@@ -413,10 +413,12 @@ function InspectedElementView({
   );
 }
 
-// The function below (formatSourceForDisplay) is based on packages/shared/describeComponentFrame.js
-const BEFORE_SLASH_RE = /^(.*)[\\\/]/;
+// This function is based on packages/shared/describeComponentFrame.js
 function formatSourceForDisplay(fileName: string, lineNumber: string) {
+  const BEFORE_SLASH_RE = /^(.*)[\\\/]/;
+
   let nameOnly = fileName.replace(BEFORE_SLASH_RE, '');
+
   // In DEV, include code for a common special case:
   // prefer "folder/index.js" instead of just "index.js".
   if (/^index\./.test(nameOnly)) {
@@ -429,6 +431,7 @@ function formatSourceForDisplay(fileName: string, lineNumber: string) {
       }
     }
   }
+
   return `${nameOnly}:${lineNumber}`;
 }