Skip to content

Commit

Permalink
These flags are hard coded in our internal config (#16883)
Browse files Browse the repository at this point in the history
By hard coding them here they can get properly DCE and don't have to be
sent to users. The internal config should only have dynamic flags.
  • Loading branch information
sebmarkbage committed Sep 25, 2019
1 parent d6d83d7 commit 0d8c0cd
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions packages/shared/forks/ReactFeatureFlags.www.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,8 @@ import typeof * as FeatureFlagsShimType from './ReactFeatureFlags.www';
export const {
debugRenderPhaseSideEffects,
debugRenderPhaseSideEffectsForStrictMode,
replayFailedUnitOfWorkWithInvokeGuardedCallback,
warnAboutDeprecatedLifecycles,
disableInputAttributeSyncing,
warnAboutShorthandPropertyCollision,
warnAboutDeprecatedSetNativeProps,
enableUserBlockingEvents,
disableLegacyContext,
disableSchedulerTimeoutBasedOnReactExpirationTime,
enableTrustedTypesIntegration,
warnAboutStringRefs,
warnAboutDefaultPropsOnFunctionComponents,
} = require('ReactFeatureFlags');

// In www, we have experimental support for gathering data
Expand All @@ -39,6 +30,16 @@ export const enableProfilerTimer = __PROFILE__;
export const enableSchedulerTracing = __PROFILE__;
export const enableSchedulerDebugging = true;

export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
export const warnAboutDeprecatedLifecycles = true;
export const warnAboutShorthandPropertyCollision = false;
export const warnAboutDeprecatedSetNativeProps = false;
export const disableLegacyContext = false;
export const warnAboutStringRefs = false;
export const warnAboutDefaultPropsOnFunctionComponents = false;
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
export const enableUserBlockingEvents = true;

export const enableStableConcurrentModeAPIs = false;

export const enableSuspenseServerRenderer = true;
Expand Down

0 comments on commit 0d8c0cd

Please sign in to comment.