Blur commit input on enter/return

facebook · Oct 5, 2020 · 14fb778 · 14fb778
1 parent 4d49ee8
commit 14fb778
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/packages/react-devtools-shared/src/devtools/views/Profiler/SnapshotSelector.js b/packages/react-devtools-shared/src/devtools/views/Profiler/SnapshotSelector.js
@@ -8,7 +8,7 @@
  */
 
 import * as React from 'react';
-import {Fragment, useCallback, useContext, useMemo} from 'react';
+import {Fragment, useCallback, useContext, useMemo, useRef} from 'react';
 import Button from '../Button';
 import ButtonIcon from '../ButtonIcon';
 import {ProfilerContext} from './ProfilerContext';
@@ -81,7 +81,20 @@ export default function SnapshotSelector(_: Props) {
   }
 
   let label = null;
-  const onCommitInputChange = useCallback(
+  const commitInputRef = useRef(null);
+  const handleCommitInputKeyDown = useCallback(event => {
+    switch (event.key) {
+      case 'Enter':
+        event.stopPropagation();
+        if (commitInputRef.current) {
+          commitInputRef.current.blur();
+        }
+        break;
+      default:
+        break;
+    }
+  }, []);
+  const handleCommitInputChange = useCallback(
     event => {
       const value = parseInt(event.target.value, 10);
       if (!isNaN(value)) {
@@ -100,13 +113,15 @@ export default function SnapshotSelector(_: Props) {
       1}`;
     const input = (
       <input
+        ref={commitInputRef}
         className={styles.Input}
         type="text"
         inputMode="numeric"
         pattern="[0-9]*"
         value={selectedFilteredCommitIndexString}
-        onChange={onCommitInputChange}
         size={numFilteredCommitsString.length}
+        onChange={handleCommitInputChange}
+        onKeyDown={handleCommitInputKeyDown}
       />
     );
     label = (