Use elementType in _updateClassComponent

facebook · Feb 11, 2019 · 19561b6 · 19561b6
1 parent 7d31954
commit 19561b6
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/packages/react-test-renderer/src/ReactShallowRenderer.js b/packages/react-test-renderer/src/ReactShallowRenderer.js
@@ -661,7 +661,7 @@ class ReactShallowRenderer {
       // In order to support react-lifecycles-compat polyfilled components,
       // Unsafe lifecycles should not be invoked for components using the new APIs.
       if (
-        typeof element.type.getDerivedStateFromProps !== 'function' &&
+        typeof elementType.getDerivedStateFromProps !== 'function' &&
         typeof this._instance.getSnapshotBeforeUpdate !== 'function'
       ) {
         if (typeof this._instance.componentWillReceiveProps === 'function') {

diff --git a/packages/react-test-renderer/src/__tests__/ReactShallowRenderer-test.js b/packages/react-test-renderer/src/__tests__/ReactShallowRenderer-test.js
@@ -1455,7 +1455,7 @@ describe('ReactShallowRenderer', () => {
     expect(logs).toEqual([undefined]);
   });
 
-  it('works with memo', () => {
+  it('should handle memo', () => {
     const Foo = () => {
       <div>Foo</div>;
     };

diff --git a/packages/react-test-renderer/src/__tests__/ReactShallowRendererMemo-test.js b/packages/react-test-renderer/src/__tests__/ReactShallowRendererMemo-test.js
@@ -1539,13 +1539,4 @@ describe('ReactShallowRendererMemo', () => {
     shallowRenderer.render(<Foo foo="bar" />);
     expect(logs).toEqual([undefined]);
   });
-
-  it('should handle memo', () => {
-    const Foo = () => {
-      <div>Foo</div>;
-    };
-    const MemoFoo = React.memo(Foo);
-    const shallowRenderer = createRenderer();
-    shallowRenderer.render(<MemoFoo />);
-  });
 });