Tidied up scheduling UMD API forwarding test (#13533)

facebook · Sep 1, 2018 · 28b9289 · 28b9289
1 parent bf8aa60
commit 28b9289
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/packages/react-scheduler/src/__tests__/SchedulingUMDBundle-test.internal.js b/packages/react-scheduler/src/__tests__/SchedulingUMDBundle-test.internal.js
@@ -16,26 +16,30 @@ describe('Scheduling UMD bundle', () => {
     jest.resetModules();
   });
 
-  function compareAPIS(apis) {
-    apis = apis.map(api => Object.keys(api).sort());
-    for (let i = 1; i < apis.length; i++) {
-      expect(apis[0]).toEqual(apis[i]);
-    }
+  function validateForwardedAPIs(api, forwardedAPIs) {
+    const apiKeys = Object.keys(api).sort();
+    forwardedAPIs.forEach(forwardedAPI => {
+      expect(Object.keys(forwardedAPI).sort()).toEqual(apiKeys);
+    });
   }
 
   it('should define the same scheduling API', () => {
+    const api = require('../../index');
     const umdAPIDev = require('../../npm/umd/react-scheduler.development');
     const umdAPIProd = require('../../npm/umd/react-scheduler.production.min');
-    const cjsAPI = require('../../index');
     const secretAPI = require('react/src/ReactSharedInternals').default;
-    compareAPIS([umdAPIDev, umdAPIProd, cjsAPI, secretAPI.Scheduler]);
+    validateForwardedAPIs(api, [umdAPIDev, umdAPIProd, secretAPI.Scheduler]);
   });
 
   it('should define the same tracking API', () => {
+    const api = require('../../tracking');
     const umdAPIDev = require('../../npm/umd/react-scheduler-tracking.development');
     const umdAPIProd = require('../../npm/umd/react-scheduler-tracking.production.min');
-    const cjsAPI = require('../../tracking');
     const secretAPI = require('react/src/ReactSharedInternals').default;
-    compareAPIS([umdAPIDev, umdAPIProd, cjsAPI, secretAPI.SchedulerTracking]);
+    validateForwardedAPIs(api, [
+      umdAPIDev,
+      umdAPIProd,
+      secretAPI.SchedulerTracking,
+    ]);
   });
 });