Skip to content

Commit

Permalink
We don't currently have a way to trace the origin of a mixin
Browse files Browse the repository at this point in the history
This makes it more difficult to find bugs in mixins both dynamically
and using a static type system.

We also don't have a way to find these to be upgraded to a new mixin
syntax if we needed to.

This hook is currently an optional noop but could be made required to
create a mixin class.
  • Loading branch information
sebmarkbage committed Jan 27, 2015
1 parent 16a56af commit 295ef00
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/browser/ui/React.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ var React = {
createClass: ReactClass.createClass,
createElement: createElement,
createFactory: createFactory,
createMixin: function(mixin) {
// Currently a noop. Will be used to validate and trace mixins.
return mixin;
},
constructAndRenderComponent: ReactMount.constructAndRenderComponent,
constructAndRenderComponentByID: ReactMount.constructAndRenderComponentByID,
findDOMNode: findDOMNode,
Expand Down

0 comments on commit 295ef00

Please sign in to comment.