Skip to content

Commit

Permalink
[be] Remove unshipped experimental <Cache> element type (#28698)
Browse files Browse the repository at this point in the history
Removes the `<Cache />` element type since we're going with a simpler
caching strategy.

DiffTrain build for [7319c61](7319c61)
  • Loading branch information
josephsavona committed Apr 2, 2024
1 parent 58f6413 commit 4af8db7
Show file tree
Hide file tree
Showing 36 changed files with 264 additions and 560 deletions.
7 changes: 0 additions & 7 deletions compiled/facebook-www/JSXDEVRuntime-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ if (__DEV__) {
var REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode");
var REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen");
var REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden");
var REACT_CACHE_TYPE = Symbol.for("react.cache");
var REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker");
var MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
var FAUX_ITERATOR_SYMBOL = "@@iterator";
Expand Down Expand Up @@ -169,11 +168,6 @@ if (__DEV__) {

case REACT_SUSPENSE_LIST_TYPE:
return "SuspenseList";

case REACT_CACHE_TYPE: {
return "Cache";
}

// Fall through

case REACT_TRACING_MARKER_TYPE:
Expand Down Expand Up @@ -345,7 +339,6 @@ if (__DEV__) {
type === REACT_LEGACY_HIDDEN_TYPE ||
type === REACT_OFFSCREEN_TYPE ||
type === REACT_SCOPE_TYPE ||
type === REACT_CACHE_TYPE ||
(enableTransitionTracing && type === REACT_TRACING_MARKER_TYPE)
) {
return true;
Expand Down
7 changes: 0 additions & 7 deletions compiled/facebook-www/JSXDEVRuntime-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ if (__DEV__) {
var REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode");
var REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen");
var REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden");
var REACT_CACHE_TYPE = Symbol.for("react.cache");
var REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker");
var MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
var FAUX_ITERATOR_SYMBOL = "@@iterator";
Expand Down Expand Up @@ -169,11 +168,6 @@ if (__DEV__) {

case REACT_SUSPENSE_LIST_TYPE:
return "SuspenseList";

case REACT_CACHE_TYPE: {
return "Cache";
}

// Fall through

case REACT_TRACING_MARKER_TYPE:
Expand Down Expand Up @@ -345,7 +339,6 @@ if (__DEV__) {
type === REACT_LEGACY_HIDDEN_TYPE ||
type === REACT_OFFSCREEN_TYPE ||
type === REACT_SCOPE_TYPE ||
type === REACT_CACHE_TYPE ||
(enableTransitionTracing && type === REACT_TRACING_MARKER_TYPE)
) {
return true;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5ab97b73457e2da72749322a1925a970a967f3bc
7319c61b18274ee7e7c20bd2e533b93c922d8fe0
10 changes: 1 addition & 9 deletions compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "19.0.0-www-classic-83a7d6d7";
var ReactVersion = "19.0.0-www-classic-da16f573";

// ATTENTION
// When adding new symbols to this file,
Expand All @@ -48,7 +48,6 @@ if (__DEV__) {
var REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode");
var REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen");
var REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden");
var REACT_CACHE_TYPE = Symbol.for("react.cache");
var REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker");
var MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
var FAUX_ITERATOR_SYMBOL = "@@iterator";
Expand Down Expand Up @@ -536,11 +535,6 @@ if (__DEV__) {

case REACT_SUSPENSE_LIST_TYPE:
return "SuspenseList";

case REACT_CACHE_TYPE: {
return "Cache";
}

// Fall through

case REACT_TRACING_MARKER_TYPE:
Expand Down Expand Up @@ -723,7 +717,6 @@ if (__DEV__) {
type === REACT_LEGACY_HIDDEN_TYPE ||
type === REACT_OFFSCREEN_TYPE ||
type === REACT_SCOPE_TYPE ||
type === REACT_CACHE_TYPE ||
(enableTransitionTracing && type === REACT_TRACING_MARKER_TYPE)
) {
return true;
Expand Down Expand Up @@ -3671,7 +3664,6 @@ if (__DEV__) {
exports.memo = memo;
exports.startTransition = startTransition;
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
exports.unstable_Cache = REACT_CACHE_TYPE;
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
exports.unstable_Scope = REACT_SCOPE_TYPE;
Expand Down
10 changes: 1 addition & 9 deletions compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "19.0.0-www-modern-93792210";
var ReactVersion = "19.0.0-www-modern-f04454d4";

// ATTENTION
// When adding new symbols to this file,
Expand All @@ -48,7 +48,6 @@ if (__DEV__) {
var REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode");
var REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen");
var REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden");
var REACT_CACHE_TYPE = Symbol.for("react.cache");
var REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker");
var MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
var FAUX_ITERATOR_SYMBOL = "@@iterator";
Expand Down Expand Up @@ -536,11 +535,6 @@ if (__DEV__) {

case REACT_SUSPENSE_LIST_TYPE:
return "SuspenseList";

case REACT_CACHE_TYPE: {
return "Cache";
}

// Fall through

case REACT_TRACING_MARKER_TYPE:
Expand Down Expand Up @@ -723,7 +717,6 @@ if (__DEV__) {
type === REACT_LEGACY_HIDDEN_TYPE ||
type === REACT_OFFSCREEN_TYPE ||
type === REACT_SCOPE_TYPE ||
type === REACT_CACHE_TYPE ||
(enableTransitionTracing && type === REACT_TRACING_MARKER_TYPE)
) {
return true;
Expand Down Expand Up @@ -3671,7 +3664,6 @@ if (__DEV__) {
exports.memo = memo;
exports.startTransition = startTransition;
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
exports.unstable_Cache = REACT_CACHE_TYPE;
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
exports.unstable_Scope = REACT_SCOPE_TYPE;
Expand Down
4 changes: 1 addition & 3 deletions compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ var REACT_ELEMENT_TYPE = Symbol.for("react.element"),
REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode"),
REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen"),
REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden"),
REACT_CACHE_TYPE = Symbol.for("react.cache"),
REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker"),
MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
function getIteratorFn(maybeIterable) {
Expand Down Expand Up @@ -568,7 +567,6 @@ exports.startTransition = function (scope, options) {
}
};
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
exports.unstable_Cache = REACT_CACHE_TYPE;
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
exports.unstable_Scope = REACT_SCOPE_TYPE;
Expand Down Expand Up @@ -660,4 +658,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "19.0.0-www-classic-b1e9d190";
exports.version = "19.0.0-www-classic-6c6f69ff";
4 changes: 1 addition & 3 deletions compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ var REACT_ELEMENT_TYPE = Symbol.for("react.element"),
REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode"),
REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen"),
REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden"),
REACT_CACHE_TYPE = Symbol.for("react.cache"),
MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
function getIteratorFn(maybeIterable) {
if (null === maybeIterable || "object" !== typeof maybeIterable) return null;
Expand Down Expand Up @@ -567,7 +566,6 @@ exports.startTransition = function (scope, options) {
}
};
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
exports.unstable_Cache = REACT_CACHE_TYPE;
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
exports.unstable_Scope = REACT_SCOPE_TYPE;
Expand Down Expand Up @@ -658,4 +656,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "19.0.0-www-modern-07d01c0d";
exports.version = "19.0.0-www-modern-763d5ed6";
4 changes: 1 addition & 3 deletions compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ var REACT_ELEMENT_TYPE = Symbol.for("react.element"),
REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode"),
REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen"),
REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden"),
REACT_CACHE_TYPE = Symbol.for("react.cache"),
REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker"),
MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
function getIteratorFn(maybeIterable) {
Expand Down Expand Up @@ -572,7 +571,6 @@ exports.startTransition = function (scope, options) {
}
};
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
exports.unstable_Cache = REACT_CACHE_TYPE;
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
exports.unstable_Scope = REACT_SCOPE_TYPE;
Expand Down Expand Up @@ -664,7 +662,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "19.0.0-www-classic-7ee6e970";
exports.version = "19.0.0-www-classic-1734cffd";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
4 changes: 1 addition & 3 deletions compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ var REACT_ELEMENT_TYPE = Symbol.for("react.element"),
REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode"),
REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen"),
REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden"),
REACT_CACHE_TYPE = Symbol.for("react.cache"),
MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
function getIteratorFn(maybeIterable) {
if (null === maybeIterable || "object" !== typeof maybeIterable) return null;
Expand Down Expand Up @@ -571,7 +570,6 @@ exports.startTransition = function (scope, options) {
}
};
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
exports.unstable_Cache = REACT_CACHE_TYPE;
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
exports.unstable_Scope = REACT_SCOPE_TYPE;
Expand Down Expand Up @@ -662,7 +660,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "19.0.0-www-modern-943af81d";
exports.version = "19.0.0-www-modern-1bb0db64";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
20 changes: 1 addition & 19 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}

var ReactVersion = "19.0.0-www-classic-910568aa";
var ReactVersion = "19.0.0-www-classic-2807bf19";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -249,7 +249,6 @@ if (__DEV__) {
var REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode");
var REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen");
var REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden");
var REACT_CACHE_TYPE = Symbol.for("react.cache");
var REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker");
var REACT_MEMO_CACHE_SENTINEL = Symbol.for("react.memo_cache_sentinel");
var MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
Expand Down Expand Up @@ -326,11 +325,6 @@ if (__DEV__) {

case REACT_SUSPENSE_LIST_TYPE:
return "SuspenseList";

case REACT_CACHE_TYPE: {
return "Cache";
}

// Fall through

case REACT_TRACING_MARKER_TYPE:
Expand Down Expand Up @@ -30178,12 +30172,6 @@ if (__DEV__) {

// Fall through

case REACT_CACHE_TYPE: {
return createFiberFromCache(pendingProps, mode, lanes, key);
}

// Fall through

case REACT_TRACING_MARKER_TYPE:
if (enableTransitionTracing) {
return createFiberFromTracingMarker(
Expand Down Expand Up @@ -30415,12 +30403,6 @@ if (__DEV__) {
fiber.stateNode = instance;
return fiber;
}
function createFiberFromCache(pendingProps, mode, lanes, key) {
var fiber = createFiber(CacheComponent, pendingProps, key, mode);
fiber.elementType = REACT_CACHE_TYPE;
fiber.lanes = lanes;
return fiber;
}
function createFiberFromTracingMarker(pendingProps, mode, lanes, key) {
var fiber = createFiber(TracingMarkerComponent, pendingProps, key, mode);
fiber.elementType = REACT_TRACING_MARKER_TYPE;
Expand Down
20 changes: 1 addition & 19 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}

var ReactVersion = "19.0.0-www-modern-9a2f3199";
var ReactVersion = "19.0.0-www-modern-3f8cc689";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -249,7 +249,6 @@ if (__DEV__) {
var REACT_DEBUG_TRACING_MODE_TYPE = Symbol.for("react.debug_trace_mode");
var REACT_OFFSCREEN_TYPE = Symbol.for("react.offscreen");
var REACT_LEGACY_HIDDEN_TYPE = Symbol.for("react.legacy_hidden");
var REACT_CACHE_TYPE = Symbol.for("react.cache");
var REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker");
var REACT_MEMO_CACHE_SENTINEL = Symbol.for("react.memo_cache_sentinel");
var MAYBE_ITERATOR_SYMBOL = Symbol.iterator;
Expand Down Expand Up @@ -326,11 +325,6 @@ if (__DEV__) {

case REACT_SUSPENSE_LIST_TYPE:
return "SuspenseList";

case REACT_CACHE_TYPE: {
return "Cache";
}

// Fall through

case REACT_TRACING_MARKER_TYPE:
Expand Down Expand Up @@ -29828,12 +29822,6 @@ if (__DEV__) {

// Fall through

case REACT_CACHE_TYPE: {
return createFiberFromCache(pendingProps, mode, lanes, key);
}

// Fall through

case REACT_TRACING_MARKER_TYPE:
if (enableTransitionTracing) {
return createFiberFromTracingMarker(
Expand Down Expand Up @@ -30065,12 +30053,6 @@ if (__DEV__) {
fiber.stateNode = instance;
return fiber;
}
function createFiberFromCache(pendingProps, mode, lanes, key) {
var fiber = createFiber(CacheComponent, pendingProps, key, mode);
fiber.elementType = REACT_CACHE_TYPE;
fiber.lanes = lanes;
return fiber;
}
function createFiberFromTracingMarker(pendingProps, mode, lanes, key) {
var fiber = createFiber(TracingMarkerComponent, pendingProps, key, mode);
fiber.elementType = REACT_TRACING_MARKER_TYPE;
Expand Down
Loading

0 comments on commit 4af8db7

Please sign in to comment.