Skip to content

Commit

Permalink
Remove the safeguard around beforeActiveInstanceBlur
Browse files Browse the repository at this point in the history
  • Loading branch information
gaearon committed Jun 11, 2021
1 parent 696c161 commit 626cd53
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 38 deletions.
20 changes: 1 addition & 19 deletions packages/react-reconciler/src/ReactFiberCommitWork.new.js
Original file line number Diff line number Diff line change
Expand Up @@ -342,24 +342,6 @@ function safelyCallDestroy(
}
}

function safelyCallBeforeInstanceBlur(fiber: Fiber) {
if (__DEV__) {
setCurrentDebugFiberInDEV(fiber);
invokeGuardedCallback(null, beforeActiveInstanceBlur, null, fiber);
if (hasCaughtError()) {
const error = clearCaughtError();
captureCommitPhaseError(fiber, fiber.return, error);
}
resetCurrentDebugFiberInDEV();
} else {
try {
beforeActiveInstanceBlur(fiber);
} catch (error) {
captureCommitPhaseError(fiber, fiber.return, error);
}
}
}

let focusedInstanceHandle: null | Fiber = null;
let shouldFireAfterActiveInstanceBlur: boolean = false;

Expand Down Expand Up @@ -428,7 +410,7 @@ function commitBeforeMutationEffects_complete() {
doesFiberContain(fiber, focusedInstanceHandle)
) {
shouldFireAfterActiveInstanceBlur = true;
safelyCallBeforeInstanceBlur(fiber);
beforeActiveInstanceBlur(fiber);
}
}
}
Expand Down
20 changes: 1 addition & 19 deletions packages/react-reconciler/src/ReactFiberCommitWork.old.js
Original file line number Diff line number Diff line change
Expand Up @@ -342,24 +342,6 @@ function safelyCallDestroy(
}
}

function safelyCallBeforeInstanceBlur(fiber: Fiber) {
if (__DEV__) {
setCurrentDebugFiberInDEV(fiber);
invokeGuardedCallback(null, beforeActiveInstanceBlur, null, fiber);
if (hasCaughtError()) {
const error = clearCaughtError();
captureCommitPhaseError(fiber, fiber.return, error);
}
resetCurrentDebugFiberInDEV();
} else {
try {
beforeActiveInstanceBlur(fiber);
} catch (error) {
captureCommitPhaseError(fiber, fiber.return, error);
}
}
}

let focusedInstanceHandle: null | Fiber = null;
let shouldFireAfterActiveInstanceBlur: boolean = false;

Expand Down Expand Up @@ -428,7 +410,7 @@ function commitBeforeMutationEffects_complete() {
doesFiberContain(fiber, focusedInstanceHandle)
) {
shouldFireAfterActiveInstanceBlur = true;
safelyCallBeforeInstanceBlur(fiber);
beforeActiveInstanceBlur(fiber);
}
}
}
Expand Down

0 comments on commit 626cd53

Please sign in to comment.