Remove extra tests for Fragment

facebook · Sep 23, 2017 · 66726c2 · 66726c2
1 parent 5284c01
commit 66726c2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 100 deletions.
diff --git a/src/isomorphic/modern/class/__tests__/ReactFragment-test.js b/src/isomorphic/modern/class/__tests__/ReactFragment-test.js
@@ -10,87 +10,17 @@
  */
 'use strict';
 
-let React;
-let ReactDOM;
-let createRenderer;
-let ReactTestRenderer;
-let ReactNoop;
-let ReactNative;
-let UIManager;
-let createReactNativeComponentClass;
-let ReactDOMFeatureFlags = require('ReactDOMFeatureFlags');
-let element;
+const React = require('react');
+const ReactNoop = require('react-noop-renderer');
 
-describe('ReactFragment', () => {
-  beforeEach(() => {
-    jest.resetModules();
-
-    React = require('react');
-
-    element = (
-      <React.Fragment>
-        hello <span>world</span>
-      </React.Fragment>
-    );
-  });
-
-  it('should render via native renderer', () => {
-    ReactNative = require('react-native');
-    UIManager = require('UIManager');
-    createReactNativeComponentClass = require('createReactNativeComponentClass');
-
-    const View = createReactNativeComponentClass('View', () => ({
-      validAttributes: {foo: true},
-      uiViewClassName: 'View',
-    }));
-    const Text = createReactNativeComponentClass('Text', () => ({
-      validAttributes: {foo: true},
-      uiViewClassName: 'Text',
-    }));
-
-    ReactNative.render(
-      <View>
-        <React.Fragment>
-          <Text foo="a">1</Text>
-          <Text foo="b">2</Text>
-        </React.Fragment>
-      </View>,
-      11,
-    );
-
-    expect(UIManager.__dumpHierarchyForJestTestsOnly()).toMatchSnapshot();
-  });
-
-  it('should render via shallow renderer', () => {
-    createRenderer = require('react-test-renderer/shallow').createRenderer;
-
-    const shallowRenderer = createRenderer();
-    shallowRenderer.render(element);
-
-    expect(shallowRenderer.getRenderOutput()).toEqual([
-      'hello ',
-      <span>world</span>,
-    ]);
-  });
-
-  it('should render via test renderer', () => {
-    ReactTestRenderer = require('react-test-renderer');
-
-    const renderer = ReactTestRenderer.create(element);
-
-    expect(renderer.toJSON()).toEqual([
-      'hello ',
-      {
-        type: 'span',
-        props: {},
-        children: ['world'],
-      },
-    ]);
-  });
+const element = (
+  <React.Fragment>
+    hello <span>world</span>
+  </React.Fragment>
+);
 
+describe('ReactFragment', () => {
   it('should render via noop renderer', () => {
-    ReactNoop = require('react-noop-renderer');
-
     ReactNoop.render(element);
     ReactNoop.flush();
 
@@ -99,15 +29,4 @@ describe('ReactFragment', () => {
       {type: 'span', children: [], prop: undefined},
     ]);
   });
-
-  if (ReactDOMFeatureFlags.useFiber) {
-    it('should render via ReactDOM', () => {
-      ReactDOM = require('react-dom');
-
-      const container = document.createElement('div');
-      ReactDOM.render(element, container);
-
-      expect(container.innerHTML).toEqual('hello <span>world</span>');
-    });
-  }
 });
diff --git a/src/isomorphic/modern/class/__tests__/__snapshots__/ReactFragment-test.js.snap b/src/isomorphic/modern/class/__tests__/__snapshots__/ReactFragment-test.js.snap
diff --git a/src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js b/src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js
@@ -179,7 +179,12 @@ describe('ReactJSXElementValidator', () => {
   it('does not warn when the element is directly as children', () => {
     spyOn(console, 'error');
 
-    void <Component><Component /><Component /></Component>;
+    void (
+      <Component>
+        <Component />
+        <Component />
+      </Component>
+    );
 
     expectDev(console.error.calls.count()).toBe(0);
   });