Skip to content

Commit

Permalink
[compiler:chore] fix SSA pdf reference link (#29162)
Browse files Browse the repository at this point in the history
## Summary

This PR fixes the deadlink in the SSA comment. Previously the attached
link is down now.

## How did you test this change?

1. I can confirm the PDF in the new link is the same as the old now.
Reference: https://www.recompiled.dev/blog/ssa/
2. I can confirm the old link is down, and it is [not just
me](https://downforeveryoneorjustme.com/pp.info.uni-karlsruhe.de?proto=https)

<img width="580" alt="image"
src="https://github.com/facebook/react/assets/2883231/eeca5eda-6f61-4ac4-a113-1b04370533d9">

---------

Co-authored-by: Jan Kassens <jkassens@meta.com>
  • Loading branch information
HerringtonDarkholme and kassens committed May 20, 2024
1 parent cca15a2 commit 68de7d0
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
* In both these cases, the phi is eliminated and all usages of the phi identifier
* are replaced with the other operand (ie in both cases above, all usages of `x2` are replaced with `x1` .
*
* The algorithm is inspired by that in https://pp.info.uni-karlsruhe.de/uploads/publikationen/braun13cc.pdf
* The algorithm is inspired by that in https://pp.ipd.kit.edu/uploads/publikationen/braun13cc.pdf
* but modified to reduce passes over the CFG. We visit the blocks in reverse postorder. Each time a redundant
* phi is encountered we add a mapping (eg x2 -> x1) to a rewrite table. Subsequent instructions, terminals,
* and phis rewrite all their identifiers based on this table. The algorithm loops over the CFG repeatedly
Expand Down

0 comments on commit 68de7d0

Please sign in to comment.